-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Fix docstring typo in subprocess.py #15812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for catching this.
give me a bit - i'm moving through CLA edit: signed it twice now (once before registering and once after - and my github username is attached to the profile). |
Thanks @xmatthias for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
(cherry picked from commit 182e1d1) Co-authored-by: Matthias <xmatthias@outlook.com>
GH-15854 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit 182e1d1) Co-authored-by: Matthias <xmatthias@outlook.com>
GH-15855 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 182e1d1) Co-authored-by: Matthias <xmatthias@outlook.com>
(cherry picked from commit 182e1d1) Co-authored-by: Matthias <xmatthias@outlook.com>
Fix docstring typo in subprocess.py
it should be
will
, notwil
, otherwise this sentence does not make sense.