Skip to content

[3.8] closes bpo-37405: Make socket.getsockname() always return a tuple for AF_CAN. (GH-14392) #16018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2019
Merged

[3.8] closes bpo-37405: Make socket.getsockname() always return a tuple for AF_CAN. (GH-14392) #16018

merged 1 commit into from
Sep 12, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 12, 2019 •
edited by bedevere-bot
Loading

This fixes a regression from 3.5. In recent releases, getsockname() in the AF_CAN case has returned a string.
(cherry picked from commit 954900a)

Co-authored-by: bggardner brent@ebrent.net

https://bugs.python.org/issue37405

@bggardner @miss-islington
closes bpo-37405: Make socket.getsockname() always return a tuple for…
8d3676d 
… AF_CAN. (pythonGH-14392)

This fixes a regression from 3.5. In recent releases, `getsockname()` in the AF_CAN case has returned a string.
(cherry picked from commit 954900a)

Co-authored-by: bggardner <brent@ebrent.net>
@bedevere-bot bedevere-bot mentioned this pull request Sep 12, 2019
Merged
@miss-islington
Copy link
Contributor Author

@bggardner and @benjaminp: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@benjaminp benjaminp merged commit f60fd95 into python:3.8 Sep 12, 2019
@miss-islington miss-islington deleted the backport-954900a-3.8 branch September 12, 2019 10:34
@miss-islington
Copy link
Contributor Author

@bggardner and @benjaminp: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@bggardner and @benjaminp: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminp benjaminp benjaminp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @benjaminp @the-knights-who-say-ni @bedevere-bot @bggardner