bpo-41344: raise ValueError when creating shared memory of size 0 #21556

vinay0410 · 2020-07-20T07:58:50Z

https://bugs.python.org/issue41344

Lib/multiprocessing/shared_memory.py

Lib/test/_test_multiprocessing.py

ericvsmith

One tiny comment, but otherwise this looks good. Thanks!

Lib/multiprocessing/shared_memory.py

vinay0410 · 2020-07-20T14:57:00Z

reopened to refresh travis-ci which hanged.

Lib/multiprocessing/shared_memory.py

ericvsmith

This looks good to me. I'd like to hear what @tiran has to say.

terryjreedy · 2020-07-25T04:30:11Z

I get the ValueError on Windows.

Misc/NEWS.d/next/Library/2020-07-20-13-27-48.bpo-41344.iKipNd.rst

Lib/multiprocessing/shared_memory.py

vinay0410 · 2020-07-30T10:24:27Z

Hi @pablogsal , could you please re-review this.

ericvsmith

This looks good to me.

vinay0410 · 2020-08-28T05:02:03Z

Hi @ericvsmith , this PR has been in awaiting merge for a long time. Is there anything pending from my side ?
If not can you please go ahead and merge this.

ericvsmith · 2020-08-30T07:51:41Z

I was hoping for another review by @pablogsal.

pablogsal · 2020-08-30T16:43:58Z

I was hoping for another review by @pablogsal.

Sorry for the delay, I will try to make another review today

ericvsmith · 2020-08-30T16:51:30Z

Thanks, Pablo. I know you're busy, and I hesitated to ask. But another pair of eyes would be good. It looks okay to me.

I am going to close and re-open this in hopes of triggering Travis.

pablogsal

LGTM

miss-islington · 2020-08-30T19:03:14Z

Thanks @vinay0410 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

…thonGH-21556) (cherry picked from commit 475a5fb) Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com>

bedevere-bot · 2020-08-30T19:03:27Z

GH-22018 is a backport of this pull request to the 3.9 branch.

bedevere-bot · 2020-08-30T19:03:35Z

GH-22019 is a backport of this pull request to the 3.8 branch.

…thonGH-21556) (cherry picked from commit 475a5fb) Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com>

pablogsal · 2020-08-30T19:03:56Z

Thanks @vinay0410 and @ericvsmith for the patience and the review. I will backport this to the relevant branches

…-21556) (GH-22018) (cherry picked from commit 475a5fb) Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com> Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com>

…-21556) (GH-22019) (cherry picked from commit 475a5fb) Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com> Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com>

pablogsal · 2020-08-30T20:11:22Z

The buildbot failures are unrelated (no space left on those machines)

bedevere-bot · 2020-08-31T15:12:15Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE Fedora Stable LTO 3.9 has failed when building commit ca55ecb.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/155/builds/571) and take a look at the build logs.
Check if the failure is related to this commit (ca55ecb) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/155/builds/571

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 2        
remote: Enumerating objects: 10, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Total 12 (delta 10), reused 10 (delta 10), pack-reused 2        
From https://github.com/python/cpython
 * branch                  3.9        -> FETCH_HEAD
Reset branch '3.9'

In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5714:25,
    inlined from ‘assemble’ at Python/compile.c:6053:18:
Python/compile.c:5668:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5668 |         *lnotab++ = k;
      |         ~~~~~~~~~~^~~
Python/compile.c: In function ‘compiler_comprehension’:
Python/compile.c:857:27: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  857 |     (c)->u->u_lineno = (x)->lineno;             \
      |                        ~~~^~~~~~~~
./Python/initconfig.c: In function ‘_PyConfig_InitCompatConfig’:
./Python/initconfig.c:611:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  611 | _PyConfig_InitCompatConfig(PyConfig *config)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
Python/compile.c: In function ‘compiler_visit_expr1’:
Python/compile.c:5123:5: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
 5123 |     SET_LOC(c, e);
      |     ^
Python/compile.c: In function ‘check_ann_subscr’:
Python/compile.c:5123:5: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
 5123 |     SET_LOC(c, e);
      |     ^
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5714:25,
    inlined from ‘assemble’ at Python/compile.c:6053:18:
Python/compile.c:5668:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5668 |         *lnotab++ = k;
      |                   ^
./Python/initconfig.c: In function ‘_PyConfig_InitCompatConfig’:
./Python/initconfig.c:611:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  611 | _PyConfig_InitCompatConfig(PyConfig *config)
      | ^
./Python/initconfig.c: In function ‘_PyConfig_InitCompatConfig’:
./Python/initconfig.c:611:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  611 | _PyConfig_InitCompatConfig(PyConfig *config)
      | ^
./Python/initconfig.c: In function ‘_PyConfig_InitCompatConfig’:
./Python/initconfig.c:611:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  611 | _PyConfig_InitCompatConfig(PyConfig *config)
      | ^
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5714:0,
    inlined from ‘assemble’ at Python/compile.c:6053:0:
Python/compile.c:5668: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5668 |         *lnotab++ = k;
      | 
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5714:0,
    inlined from ‘assemble’ at Python/compile.c:6053:0:
Python/compile.c:5668: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5668 |         *lnotab++ = k;
      | 
At top level:
lto1: fatal error: error writing to /tmp/ccD26ECW.s: No space left on device
compilation terminated.
lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make: *** [Makefile:602: python] Error 1
make: *** Waiting for unfinished jobs....
At top level:
lto1: fatal error: error writing to /tmp/ccSd8vS0.s: No space left on device
compilation terminated.
lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make: *** [Makefile:737: Programs/_testembed] Error 1

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:1854: clean-retain-profile] Error 1 (ignored)

bedevere-bot · 2020-08-31T15:19:38Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE Fedora Stable LTO 3.8 has failed when building commit 38e3287.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/161/builds/1068) and take a look at the build logs.
Check if the failure is related to this commit (38e3287) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/161/builds/1068

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 2        
remote: Enumerating objects: 10, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Total 12 (delta 10), reused 10 (delta 10), pack-reused 2        
From https://github.com/python/cpython
 * branch                  3.8        -> FETCH_HEAD
Reset branch '3.8'

Objects/longobject.c: In function ‘_PyLong_Frexp’:
Objects/longobject.c:2989:33: warning: ‘x_digits[0]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 2989 |                     x_digits[0] |= 1;
      |                                 ^~
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5692:25,
    inlined from ‘assemble’ at Python/compile.c:6031:18:
Python/compile.c:5646:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5646 |         *lnotab++ = k;
      |         ~~~~~~~~~~^~~
Python/initconfig.c: In function ‘_PyConfig_InitCompatConfig’:
Python/initconfig.c:605:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  605 | _PyConfig_InitCompatConfig(PyConfig *config)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
Python/compile.c: In function ‘compiler_visit_stmt’:
Python/compile.c:2931:24: note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5
 2931 |     c->u->u_lineno_set = 0;
      |     ~~~~~~~~~~~~~~~~~~~^~~
Python/compile.c: In function ‘compiler_visit_stmt’:
Python/compile.c:2931:24: note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5
 2931 |     c->u->u_lineno_set = 0;
      |                        ^
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5692:25,
    inlined from ‘assemble’ at Python/compile.c:6031:18:
Python/compile.c:5646:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5646 |         *lnotab++ = k;
      |                   ^
Python/initconfig.c: In function ‘_PyConfig_InitCompatConfig’:
Python/initconfig.c:605:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  605 | _PyConfig_InitCompatConfig(PyConfig *config)
      | ^
Python/initconfig.c: In function ‘_PyConfig_InitCompatConfig’:
Python/initconfig.c:605:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  605 | _PyConfig_InitCompatConfig(PyConfig *config)
      | ^
Python/initconfig.c: In function ‘_PyConfig_InitCompatConfig’:
Python/initconfig.c:605:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  605 | _PyConfig_InitCompatConfig(PyConfig *config)
      | ^
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5692:0,
    inlined from ‘assemble’ at Python/compile.c:6031:0:
Python/compile.c:5646: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5646 |         *lnotab++ = k;
      | 
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5692:0,
    inlined from ‘assemble’ at Python/compile.c:6031:0:
Python/compile.c:5646: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5646 |         *lnotab++ = k;
      | 
At top level:
lto1: fatal error: error writing to /tmp/ccDElbe9.s: No space left on device
compilation terminated.
lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make: *** [Makefile:578: python] Error 1
make: *** Waiting for unfinished jobs....
At top level:
lto1: fatal error: error writing to /tmp/ccnRWY5c.s: No space left on device
compilation terminated.
lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make: *** [Makefile:709: Programs/_testembed] Error 1

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:1778: clean] Error 1 (ignored)

…thonGH-21556)

vinay0410 requested a review from tiran as a code owner July 20, 2020 07:58

the-knights-who-say-ni added the CLA signed label Jul 20, 2020

bedevere-bot added the awaiting review label Jul 20, 2020

ericvsmith reviewed Jul 20, 2020

View reviewed changes

Lib/multiprocessing/shared_memory.py Outdated Show resolved Hide resolved

Lib/test/_test_multiprocessing.py Show resolved Hide resolved

vinay0410 force-pushed the fix-issue-41344 branch from 6fb4e46 to 9ec4945 Compare July 20, 2020 14:02

vinay0410 requested a review from ericvsmith July 20, 2020 14:04

ericvsmith reviewed Jul 20, 2020

View reviewed changes

Lib/multiprocessing/shared_memory.py Show resolved Hide resolved

vinay0410 force-pushed the fix-issue-41344 branch from 9ec4945 to 5b2d366 Compare July 20, 2020 14:17

vinay0410 requested a review from ericvsmith July 20, 2020 14:18

vinay0410 closed this Jul 20, 2020

vinay0410 reopened this Jul 20, 2020

ericvsmith reviewed Jul 20, 2020

View reviewed changes

Lib/multiprocessing/shared_memory.py Outdated Show resolved Hide resolved

vinay0410 force-pushed the fix-issue-41344 branch from 5b2d366 to 1752c45 Compare July 20, 2020 15:54

ericvsmith reviewed Jul 20, 2020

View reviewed changes

pablogsal reviewed Jul 27, 2020

View reviewed changes

Misc/NEWS.d/next/Library/2020-07-20-13-27-48.bpo-41344.iKipNd.rst Outdated Show resolved Hide resolved

pablogsal reviewed Jul 27, 2020

View reviewed changes

Lib/multiprocessing/shared_memory.py Outdated Show resolved Hide resolved

bpo-41344: raise ValueError when creating shared memory of size 0

3fc4ab7

vinay0410 force-pushed the fix-issue-41344 branch from 1752c45 to 3fc4ab7 Compare July 28, 2020 04:59

vinay0410 requested a review from pablogsal July 28, 2020 05:03

ericvsmith approved these changes Jul 30, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jul 30, 2020

ericvsmith closed this Aug 30, 2020

ericvsmith reopened this Aug 30, 2020

pablogsal approved these changes Aug 30, 2020

View reviewed changes

pablogsal added needs backport to 3.8 needs backport to 3.9 only security fixes labels Aug 30, 2020

pablogsal merged commit 475a5fb into python:master Aug 30, 2020

bedevere-bot removed the awaiting merge label Aug 30, 2020

bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 30, 2020

bedevere-bot removed the needs backport to 3.8 label Aug 30, 2020

python deleted a comment from bedevere-bot Aug 30, 2020

vinay0410 mentioned this pull request Aug 31, 2020

bpo-39584: raise ValueError when creating shared memory of size greater than 1TB #21877

Closed

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020

bpo-41344: Raise ValueError when creating shared memory of size 0 (py…

f4f3c61

…thonGH-21556)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-41344: raise ValueError when creating shared memory of size 0 #21556

bpo-41344: raise ValueError when creating shared memory of size 0 #21556

vinay0410 commented Jul 20, 2020 •

edited by bedevere-bot

Loading

ericvsmith left a comment

vinay0410 commented Jul 20, 2020

ericvsmith left a comment

terryjreedy commented Jul 25, 2020

vinay0410 commented Jul 30, 2020

ericvsmith left a comment

vinay0410 commented Aug 28, 2020

ericvsmith commented Aug 30, 2020

pablogsal commented Aug 30, 2020

ericvsmith commented Aug 30, 2020

pablogsal left a comment

miss-islington commented Aug 30, 2020

bedevere-bot commented Aug 30, 2020

bedevere-bot commented Aug 30, 2020

pablogsal commented Aug 30, 2020

pablogsal commented Aug 30, 2020

bedevere-bot commented Aug 31, 2020

bedevere-bot commented Aug 31, 2020

bpo-41344: raise ValueError when creating shared memory of size 0 #21556

bpo-41344: raise ValueError when creating shared memory of size 0 #21556

Conversation

vinay0410 commented Jul 20, 2020 • edited by bedevere-bot Loading

ericvsmith left a comment

Choose a reason for hiding this comment

vinay0410 commented Jul 20, 2020

ericvsmith left a comment

Choose a reason for hiding this comment

terryjreedy commented Jul 25, 2020

vinay0410 commented Jul 30, 2020

ericvsmith left a comment

Choose a reason for hiding this comment

vinay0410 commented Aug 28, 2020

ericvsmith commented Aug 30, 2020

pablogsal commented Aug 30, 2020

ericvsmith commented Aug 30, 2020

pablogsal left a comment

Choose a reason for hiding this comment

miss-islington commented Aug 30, 2020

bedevere-bot commented Aug 30, 2020

bedevere-bot commented Aug 30, 2020

pablogsal commented Aug 30, 2020

pablogsal commented Aug 30, 2020

bedevere-bot commented Aug 31, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Aug 31, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

vinay0410 commented Jul 20, 2020 •

edited by bedevere-bot

Loading