-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-38443: Check that the specified universal architectures work #22910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
GH-23451 is a backport of this pull request to the 3.9 branch. |
…honGH-22910) As [bpo-38443]() says the error message from configure when specifying --enable-universalsdk with a set of architectures that is not supported by the compiler is not very helpful. This PR explicitly checks if the compiler works and bails out if it doesn't. (cherry picked from commit 0f20bd9) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-23452 is a backport of this pull request to the 3.8 branch. |
…honGH-22910) As [bpo-38443]() says the error message from configure when specifying --enable-universalsdk with a set of architectures that is not supported by the compiler is not very helpful. This PR explicitly checks if the compiler works and bails out if it doesn't. (cherry picked from commit 0f20bd9) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
GH-22910) (GH-23451) As [[bpo-38443]()]() says the error message from configure when specifying --enable-universalsdk with a set of architectures that is not supported by the compiler is not very helpful. This PR explicitly checks if the compiler works and bails out if it doesn't. (cherry picked from commit 0f20bd9) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
…22910) As [bpo-38443]() says the error message from configure when specifying --enable-universalsdk with a set of architectures that is not supported by the compiler is not very helpful. This PR explicitly checks if the compiler works and bails out if it doesn't. (cherry picked from commit 0f20bd9) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
…honGH-22910) As [bpo-38443]() says the error message from configure when specifying --enable-universalsdk with a set of architectures that is not supported by the compiler is not very helpful. This PR explicitly checks if the compiler works and bails out if it doesn't.
As bpo-38443 says the error message from configure when specifying --enable-universalsdk with a set of architectures that is not supported by the compiler is not very helpful. This PR explicitly checks if the compiler works and bails out if it doesn't.
https://bugs.python.org/issue38443
Automerge-Triggered-By: GH:ned-deily