Skip to content

bpo-42474: add TracebackException comparison tests for non-equal inst… #23522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2020
Merged

bpo-42474: add TracebackException comparison tests for non-equal inst… #23522

merged 3 commits into from
Nov 27, 2020

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 26, 2020 •
edited by bedevere-bot
Loading

…ances of this type

Currently there are no tests for comparison between non-equal instances of traceback.TracebackException, so changing it's eq to return True instead of self.dict == other.dict would not break any tests.

https://bugs.python.org/issue42474

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Nov 26, 2020
@iritkatriel iritkatriel mentioned this pull request Nov 26, 2020
Closed
gvanrossum
gvanrossum reviewed Nov 27, 2020
View reviewed changes
iritkatriel and others added 2 commits November 27, 2020 08:55
@iritkatriel @gvanrossum
Update Lib/test/test_traceback.py
5db2200 
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
@iritkatriel @gvanrossum
Update Lib/test/test_traceback.py
4484d8c 
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
gvanrossum
gvanrossum approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix. Thanks!

@gvanrossum gvanrossum merged commit 44ca05a into python:master Nov 27, 2020
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @iritkatriel and @gvanrossum, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 44ca05afc89c9967f5dbc6c3ad89fc298c460e93 3.8

@miss-islington
Copy link
Contributor

Sorry @iritkatriel and @gvanrossum, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 44ca05afc89c9967f5dbc6c3ad89fc298c460e93 3.9

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Nov 29, 2020
@iritkatriel
[3.9] bpo-42474: test TracebackException comparison to non-equal inst…
287f0e9 
…ances (pythonGH-23522)

Closes bpo-42474
@iritkatriel iritkatriel mentioned this pull request Nov 29, 2020
Merged
@bedevere-bot
Copy link

GH-23557 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 29, 2020
@iritkatriel iritkatriel mentioned this pull request Nov 29, 2020
Merged
@bedevere-bot
Copy link

GH-23558 is a backport of this pull request to the 3.8 branch.

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Nov 29, 2020
@iritkatriel
[3.8] bpo-42474: test TracebackException comparison to non-equal inst…
6eddab2 
…ances (pythonGH-23522)

Closes bpo-42474
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@iritkatriel @adorilson
bpo-42474: test TracebackException comparison to non-equal instances (p…
d337115 
…ythonGH-23522)

Closes bpo-42474
@iritkatriel iritkatriel deleted the bpo-42474 branch March 16, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

@gvanrossum gvanrossum

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iritkatriel @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni