Skip to content

bpo-42474: add TracebackException comparison tests for non-equal inst… #23522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2020
Merged

bpo-42474: add TracebackException comparison tests for non-equal inst… #23522

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccf80a0
bpo-42474: add TracebackException comparison tests for non-equal inst…
iritkatriel Nov 26, 2020
5db2200
Update Lib/test/test_traceback.py
iritkatriel Nov 27, 2020
4484d8c
Update Lib/test/test_traceback.py
iritkatriel Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 39 additions & 2 deletions Lib/test/test_traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,7 @@ def test_context(self):
self.assertEqual(exc_info[0], exc.exc_type)
self.assertEqual(str(exc_info[1]), str(exc))

def test_comparison(self):
def test_comparison_basic(self):
try:
1/0
except Exception:
Expand All @@ -1135,6 +1135,43 @@ def test_comparison(self):
self.assertNotEqual(exc, object())
self.assertEqual(exc, ALWAYS_EQ)

def test_comparison_params_variations(self):
def raise_exc():
try:
raise ValueError('bad value')
except:
raise

def raise_with_locals():
x, y = 1, 2
raise_exc()

try:
raise_with_locals()
except Exception:
exc_info = sys.exc_info()

exc = traceback.TracebackException(*exc_info)
exc1 = traceback.TracebackException(*exc_info, limit=10)
exc2 = traceback.TracebackException(*exc_info, limit=2)

self.assertEqual(exc, exc1) # limit=10 gets all frames
self.assertNotEqual(exc, exc2) # limit=2 truncates the output

# locals change the output
exc3 = traceback.TracebackException(*exc_info, capture_locals=True)
self.assertNotEqual(exc, exc3)

# there are no locals in the innermost frame
exc4 = traceback.TracebackException(*exc_info, limit=-1)
exc5 = traceback.TracebackException(*exc_info, limit=-1, capture_locals=True)
self.assertEqual(exc4, exc5)

# there are locals in the next-to-innermost frame
exc6 = traceback.TracebackException(*exc_info, limit=-2)
exc7 = traceback.TracebackException(*exc_info, limit=-2, capture_locals=True)
self.assertNotEqual(exc6, exc7)

def test_unhashable(self):
class UnhashableException(Exception):
def __eq__(self, other):
Expand Down Expand Up @@ -1176,7 +1213,7 @@ def test_lookup_lines(self):
f = test_frame(c, None, None)
tb = test_tb(f, 6, None)
exc = traceback.TracebackException(Exception, e, tb, lookup_lines=False)
self.assertEqual({}, linecache.cache)
self.assertEqual(linecache.cache, {})
linecache.updatecache('/foo.py', globals())
self.assertEqual(exc.stack[0].line, "import sys")

Expand Down