Skip to content

bpo-43971: documentation: Added spacing according to PEP 8 #25702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2021
Merged

bpo-43971: documentation: Added spacing according to PEP 8 #25702

merged 1 commit into from
Apr 30, 2021

Conversation

moselhy
Copy link
Contributor

@moselhy moselhy commented Apr 29, 2021 •
edited by bedevere-bot
Loading

@moselhy moselhy requested a review from ericvsmith as a code owner April 29, 2021 00:35
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Apr 29, 2021
@Mariatta Mariatta mentioned this pull request Apr 30, 2021
Closed
@python python deleted a comment from the-knights-who-say-ni Apr 30, 2021
@terryjreedy
Copy link
Member

Ubuntu failures are test_asyncio. Code tests should not be running for doc change.

@terryjreedy terryjreedy merged commit e726a90 into python:master Apr 30, 2021
@miss-islington
Copy link
Contributor

Thanks @moselhy for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-25765 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-25766 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2021
@moselhy @miss-islington
bpo-43971: Add spaces around annotated arg default '=' (pythonGH-25702)
ff386e5 
Result: "quantity_on_hand: int = 0".
(cherry picked from commit e726a90)

Co-authored-by: Mohamed Moselhy <look4d@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2021
@moselhy @miss-islington
bpo-43971: Add spaces around annotated arg default '=' (pythonGH-25702)
8ca086d 
Result: "quantity_on_hand: int = 0".
(cherry picked from commit e726a90)

Co-authored-by: Mohamed Moselhy <look4d@gmail.com>
terryjreedy pushed a commit that referenced this pull request May 1, 2021
@miss-islington @moselhy
bpo-43971: Add spaces around annotated arg default '=' (GH-25702)
e48405a 
Result: "quantity_on_hand: int = 0".
(cherry picked from commit e726a90)

Co-authored-by: Mohamed Moselhy <look4d@gmail.com>

Co-authored-by: Mohamed Moselhy <look4d@gmail.com>
terryjreedy pushed a commit that referenced this pull request May 1, 2021
@miss-islington @moselhy
bpo-43971: Add spaces around annotated arg default '=' (GH-25702)
606bb1c 
Result: "quantity_on_hand: int = 0".
(cherry picked from commit e726a90)

Co-authored-by: Mohamed Moselhy <look4d@gmail.com>

Co-authored-by: Mohamed Moselhy <look4d@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moselhy @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni