bpo-44647: Fix test_httpservers failing on Unicode characters in os.environ on Windows #27161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disabling |
|
Looks like this is an Azure Pipelines problem. All the passing PRs that don't trip over
While all the PRs that fail in
|
db40e30 to
fbbb3c3
Compare
|
OK, back to square one. There are newer PRs on image 20210711.1 that pass. Knowing my luck, the failures are because my name is Łukasz. |
THIS WAS SUPPOSED TO BE A JOKE
|
pablogsal
approved these changes
Jul 15, 2021
|
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-27169 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2021
…nviron on Windows (pythonGH-27161) pythonGH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test. (cherry picked from commit 82b218f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
|
GH-27170 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2021
…nviron on Windows (pythonGH-27161) pythonGH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test. (cherry picked from commit 82b218f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv
added a commit
that referenced
this pull request
Jul 15, 2021
…nviron on Windows (GH-27161) (#27169) GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test. (cherry picked from commit 82b218f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv
added a commit
that referenced
this pull request
Jul 15, 2021
…nviron on Windows (GH-27161) (#27170) GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test. (cherry picked from commit 82b218f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of
os.environon the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.Check the issue for more details, and the comments in this PR for hunting the root cause down. This was first encountered when working on GH-27115.
https://bugs.python.org/issue44647