bpo-41735: Fix thread lock in zlib.Decompress.flush() may go wrong #29587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting `.unconsumed_tail` before acquiring the thread lock may mix up decompress state.
gpshead
approved these changes
Nov 26, 2021
|
PR #29588 does this for 3.9; as the backport automation may fail for 3.9/3.8 I'll use that for those if necessary. |
|
Thanks @animalize for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10. |
|
Sorry, @animalize and @gpshead, I could not cleanly backport this to |
|
GH-29811 is a backport of this pull request to the 3.10 branch. |
|
Sorry @animalize and @gpshead, I had trouble checking out the |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 27, 2021
…ythonGH-29587) * Fix thread lock in zlib.Decompress.flush() may go wrong Getting `.unconsumed_tail` before acquiring the thread lock may mix up decompress state. (cherry picked from commit 7edb627) Co-authored-by: Ma Lin <animalize@users.noreply.github.com>
gpshead
pushed a commit
that referenced
this pull request
Nov 27, 2021
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 27, 2021
…ong (pythonGH-29588) * Fix thread lock in zlib.Decompress.flush() may go wrong Getting `.unconsumed_tail` before acquiring the thread lock may mix up decompress state. backport of python#29587 to 3.9/3.8. (cherry picked from commit 86c1265) Co-authored-by: Ma Lin <animalize@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Nov 27, 2021
…rong (GH-29587) (GH-29811) * Fix thread lock in zlib.Decompress.flush() may go wrong Getting `.unconsumed_tail` before acquiring the thread lock may mix up decompress state. (cherry picked from commit 7edb627) Co-authored-by: Ma Lin <animalize@users.noreply.github.com> Automerge-Triggered-By: GH:gpshead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41735