Skip to content

[3.8] [3.9] bpo-41735: Fix thread lock in zlib.Decompress.flush() may go wrong (GH-29588) #29812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.8] [3.9] bpo-41735: Fix thread lock in zlib.Decompress.flush() may go wrong (GH-29588) #29812

wants to merge 1 commit into from
+6 −3

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 27, 2021 •
edited
Loading

  • Fix thread lock in zlib.Decompress.flush() may go wrong
    Getting .unconsumed_tail before acquiring the thread lock may mix up decompress state.

backport of #29587 to 3.9/3.8.
(cherry picked from commit 86c1265)

Co-authored-by: Ma Lin animalize@users.noreply.github.com

https://bugs.python.org/issue41735

Automerge-Triggered-By: GH:gpshead

@miss-islington
[3.9] bpo-41735: Fix thread lock in zlib.Decompress.flush() may go wr…
4cb4863 
…ong (pythonGH-29588)

* Fix thread lock in zlib.Decompress.flush() may go wrong
Getting `.unconsumed_tail` before acquiring the thread lock may mix up decompress state.

backport of python#29587 to 3.9/3.8.
(cherry picked from commit 86c1265)

Co-authored-by: Ma Lin <animalize@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this pull request Nov 27, 2021
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Nov 27, 2021
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@miss-islington
Copy link
Contributor Author

@animalize and @gpshead: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 28, 2021
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 29, 2021
@vstinner
Copy link
Member

@gpshead: Is this a security fix? Python 3.8 no longer accept bugfixes.

https://bugs.python.org/issue41735 is not marked as a security fix.

cc @ambv

@gpshead gpshead closed this Jan 23, 2022
@miss-islington miss-islington deleted the backport-86c1265-3.8 branch January 23, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@ambv ambv

Labels
awaiting merge type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @vstinner @gpshead @ambv @the-knights-who-say-ni @bedevere-bot