-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-92240 : Include release dates for "What's New In Python 3.X" #92937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added release dates for "What's New in Python 3.X" for 3.0, 3.1, 3.2, 3.8 and 3.10
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Doc/whatsnew/3.0.rst
Outdated
*intentionally backwards incompatible* Python release. There are more | ||
changes than in a typical release, and more that are important for all | ||
Python users. Nevertheless, after digesting the changes, you'll find | ||
*intentionally backwards incompatible* Python release. Python 3.0 was released on 3 Dec 2008. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the date formatting should be (somewhat) consistent, at least for the whatsnew pages changed in this PR. Looking at 3.9's whatsnew, it has it as 'October 5th, 2020', and 3.7 has it as 'June 27, 2018', so month, day, year
seems like a good enough standard to go off in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with date formatting consistency. Made adjustments to all versions.
2.1 - 'made' changed to 'released' 2.3, 2.6, 3.2 - whitespace and punctuation adjusted. 2.5 - release date added. 3.0, 3.1, 3.10, 3.8, 3.9 - date format adjusted.
Doc/whatsnew/2.1.rst
Outdated
@@ -27,7 +27,7 @@ of new releases, with a new release coming every 6 to 9 months. 2.1 is the first | |||
release to come out at this faster pace, with the first alpha appearing in | |||
January, 3 months after the final version of 2.0 was released. | |||
|
|||
The final release of Python 2.1 was made on April 17, 2001. | |||
The final release of Python 2.1 was released on April 17, 2001. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"release ... was released" doesn't scan terribly well. I don't think this line needs to change.
A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was made to retain consistency throughout the entire documentation among different versions. TBH, it is definitely not made on April 17, 2001 rather released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the text of a 21-year old whatsnew document purely for consistency seems iffy, I remain -1 on it.
A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, this change is unnecessary
Please also update NEWS as you've expanded to 2.X. A |
Doc/whatsnew/2.3.rst
Outdated
@@ -8,7 +8,7 @@ | |||
|
|||
.. $Id: whatsnew23.tex 54631 2007-03-31 11:58:36Z georg.brandl $ | |||
|
|||
This article explains the new features in Python 2.3. Python 2.3 was released | |||
This article explains the new features in Python 2.3. Python 2.3 was released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, double spacing was commonly used in documents in the past (and still is by some authors) -- see the remainder of What's New in Python 2.3 where .
(full stop with two literal space characters) is used frequently. Please revert this change.
A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
& also please revert where you've changed a double space to a single space in other documents (e.g. 3.0).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted mentioned double space. 3.0 release date was added later because it was missing. But it's adjusted to double spacing now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Doc/whatsnew/2.1.rst
Outdated
@@ -27,7 +27,7 @@ of new releases, with a new release coming every 6 to 9 months. 2.1 is the first | |||
release to come out at this faster pace, with the first alpha appearing in | |||
January, 3 months after the final version of 2.0 was released. | |||
|
|||
The final release of Python 2.1 was made on April 17, 2001. | |||
The final release of Python 2.1 was released on April 17, 2001. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, this change is unnecessary
Misc/NEWS.d/next/Documentation/2022-05-18-23-58-26.gh-issue-92240.bHvYiz.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
…240.bHvYiz.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Thanks @georgically for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Thanks @georgically for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
…pythonGH-92937) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> (cherry picked from commit 877ad7b) Co-authored-by: georgically <40323509+georgically@users.noreply.github.com>
GH-93328 is a backport of this pull request to the 3.10 branch. |
GH-93329 is a backport of this pull request to the 3.11 branch. |
…pythonGH-92937) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> (cherry picked from commit 877ad7b) Co-authored-by: georgically <40323509+georgically@users.noreply.github.com>
Added release dates for
"What's New in Python 3.X" for 3.0, 3.1, 3.2, 3.8 and 3.10
#92240