Skip to content

gh-92240 : Include release dates for "What's New In Python 3.X" #92937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 29, 2022
Merged

gh-92240 : Include release dates for "What's New In Python 3.X" #92937

merged 15 commits into from
May 29, 2022

Conversation

georgically
Copy link
Contributor

@georgically georgically commented May 18, 2022 •
edited by JelleZijlstra
Loading

Added release dates for
"What's New in Python 3.X" for 3.0, 3.1, 3.2, 3.8 and 3.10

#92240

@georgically
Include release dates for "What's New In Python 3.X"- (python#92240)
04353f8 
Added release dates for
"What's New in Python 3.X" for 3.0, 3.1, 3.2, 3.8 and 3.10
@ghost
Copy link

ghost commented May 18, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 18, 2022
slateny
slateny reviewed May 19, 2022
View reviewed changes
Doc/whatsnew/3.0.rst Outdated
*intentionally backwards incompatible* Python release. There are more
changes than in a typical release, and more that are important for all
Python users. Nevertheless, after digesting the changes, you'll find
*intentionally backwards incompatible* Python release. Python 3.0 was released on 3 Dec 2008.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the date formatting should be (somewhat) consistent, at least for the whatsnew pages changed in this PR. Looking at 3.9's whatsnew, it has it as 'October 5th, 2020', and 3.7 has it as 'June 27, 2018', so month, day, year seems like a good enough standard to go off in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with date formatting consistency. Made adjustments to all versions.

@georgically
Edited date formatting for all what's new versions
69cd545 
2.1 - 'made' changed to 'released'
2.3, 2.6, 3.2  - whitespace and punctuation adjusted.
2.5 - release date added.
3.0, 3.1, 3.10, 3.8, 3.9 - date format adjusted.
@georgically
Merge branch 'python#92240-whats-new' of https://github.com/georgical…
07963e2 
…ly/cpython into python#92240-whats-new
@georgically
Merge branch 'main' into python#92240-whats-new
587a857
AA-Turner
AA-Turner reviewed May 20, 2022
View reviewed changes
Doc/whatsnew/2.1.rst Outdated
@@ -27,7 +27,7 @@ of new releases, with a new release coming every 6 to 9 months. 2.1 is the first
release to come out at this faster pace, with the first alpha appearing in
January, 3 months after the final version of 2.0 was released.

The final release of Python 2.1 was made on April 17, 2001.
The final release of Python 2.1 was released on April 17, 2001.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"release ... was released" doesn't scan terribly well. I don't think this line needs to change.

A

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made to retain consistency throughout the entire documentation among different versions. TBH, it is definitely not made on April 17, 2001 rather released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the text of a 21-year old whatsnew document purely for consistency seems iffy, I remain -1 on it.

A

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this change is unnecessary

@AA-Turner
Copy link
Member

Please also update NEWS as you've expanded to 2.X.

A

AA-Turner
AA-Turner reviewed May 21, 2022
View reviewed changes
Doc/whatsnew/2.3.rst Outdated
@@ -8,7 +8,7 @@

.. $Id: whatsnew23.tex 54631 2007-03-31 11:58:36Z georg.brandl $

This article explains the new features in Python 2.3. Python 2.3 was released
This article explains the new features in Python 2.3. Python 2.3 was released
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, double spacing was commonly used in documents in the past (and still is by some authors) -- see the remainder of What's New in Python 2.3 where . (full stop with two literal space characters) is used frequently. Please revert this change.

A

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

& also please revert where you've changed a double space to a single space in other documents (e.g. 3.0).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted mentioned double space. 3.0 release date was added later because it was missing. But it's adjusted to double spacing now.

JelleZijlstra
JelleZijlstra reviewed May 22, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Doc/whatsnew/2.1.rst Outdated
@@ -27,7 +27,7 @@ of new releases, with a new release coming every 6 to 9 months. 2.1 is the first
release to come out at this faster pace, with the first alpha appearing in
January, 3 months after the final version of 2.0 was released.

The final release of Python 2.1 was made on April 17, 2001.
The final release of Python 2.1 was released on April 17, 2001.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this change is unnecessary

georgically and others added 7 commits May 22, 2022 04:07
@georgically @JelleZijlstra
Update Doc/whatsnew/3.0.rst
c39c4df 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@georgically @JelleZijlstra
Update Doc/whatsnew/3.10.rst
1e9e19e 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@georgically @JelleZijlstra
Update Doc/whatsnew/3.2.rst
9a9b457 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@georgically @JelleZijlstra
Update Misc/NEWS.d/next/Documentation/2022-05-18-23-58-26.gh-issue-92…
1580738 
…240.bHvYiz.rst

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@georgically @JelleZijlstra
Update Doc/whatsnew/3.8.rst
50bf929 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@georgically
Merge branch 'python:main' into python#92240-whats-new
0e074b2
@georgically
undo whitespaces changes from 2.X
ee770fb
AA-Turner
AA-Turner reviewed May 26, 2022
View reviewed changes
@JelleZijlstra @AA-Turner
Update Doc/whatsnew/3.1.rst
2958514 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@JelleZijlstra JelleZijlstra self-assigned this May 28, 2022
@JelleZijlstra JelleZijlstra merged commit 877ad7b into python:main May 29, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels May 29, 2022
@miss-islington
Copy link
Contributor

Thanks @georgically for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @georgically for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2022
@georgically @miss-islington
pythongh-92240 : Include release dates for "What's New In Python 3.X" (…
1af728b 
…pythonGH-92937)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
(cherry picked from commit 877ad7b)

Co-authored-by: georgically <40323509+georgically@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 29, 2022
@bedevere-bot
Copy link

GH-93328 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

GH-93329 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2022
@georgically @miss-islington
pythongh-92240 : Include release dates for "What's New In Python 3.X" (…
7f0e39f 
…pythonGH-92937)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
(cherry picked from commit 877ad7b)

Co-authored-by: georgically <40323509+georgically@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 29, 2022
@georgically georgically deleted the #92240-whats-new branch May 29, 2022 03:34
miss-islington added a commit that referenced this pull request May 29, 2022
@miss-islington @georgically
gh-92240 : Include release dates for "What's New In Python 3.X" (GH-9…
624fc61 
…2937)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
(cherry picked from commit 877ad7b)

Co-authored-by: georgically <40323509+georgically@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 29, 2022
@miss-islington @georgically
gh-92240 : Include release dates for "What's New In Python 3.X" (GH-9…
738c730 
…2937)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
(cherry picked from commit 877ad7b)

Co-authored-by: georgically <40323509+georgically@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@slateny slateny Awaiting requested review from slateny

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@georgically @bedevere-bot @AA-Turner @miss-islington @JelleZijlstra @slateny