Skip to content

[3.7] bpo-34537: Fix test_gdb:test_strings with LC_ALL=C (GH-9483) #9485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2018
Merged

[3.7] bpo-34537: Fix test_gdb:test_strings with LC_ALL=C (GH-9483) #9485

merged 1 commit into from
Sep 22, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 22, 2018 •
edited by bedevere-bot
Loading

We cannot simply call locale.getpreferredencoding() here,
as GDB might have been linked against a different version
of Python with a different encoding and coercion policy
with respect to PEP 538 and PEP 540.

Thanks to Victor Stinner for a hint on how to fix this.
(cherry picked from commit 7279b51)

Co-authored-by: Elvis Pranskevichus elvis@magic.io

https://bugs.python.org/issue34537

@elprans @miss-islington
bpo-34537: Fix test_gdb:test_strings with LC_ALL=C (pythonGH-9483)
b6b5646 
We cannot simply call locale.getpreferredencoding() here,
as GDB might have been linked against a different version
of Python with a different encoding and coercion policy
with respect to PEP 538 and PEP 540.

Thanks to Victor Stinner for a hint on how to fix this.
(cherry picked from commit 7279b51)

Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Sep 22, 2018
@bedevere-bot bedevere-bot mentioned this pull request Sep 22, 2018
Merged
vstinner
vstinner approved these changes Sep 22, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good bot.

@miss-islington
Copy link
Contributor Author

@elprans and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit e5fde1f into python:3.7 Sep 22, 2018
@miss-islington miss-islington deleted the backport-7279b51-3.7 branch September 22, 2018 01:29
@miss-islington
Copy link
Contributor Author

@elprans and @vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @elprans