Skip to content

gh-95380: Remove limitation of 1024 max path size for fcntl #95429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-95380: Remove limitation of 1024 max path size for fcntl #95429

wants to merge 1 commit into from

Conversation

gst
Copy link
Contributor

@gst gst commented Jul 29, 2022 •
edited by bedevere-bot
Loading

@gst gst mentioned this pull request Jul 29, 2022
Closed
@gst gst force-pushed the fix-fcntl-1024-limit branch 3 times, most recently from 2e4ff61 to ab78e70 Compare July 29, 2022 14:30
@gst gst marked this pull request as ready for review July 29, 2022 15:04
@arhadthedev arhadthedev mentioned this pull request Jul 29, 2022
Open
arhadthedev added a commit to arhadthedev/cpython that referenced this pull request Jul 29, 2022
@arhadthedev
Убрать fcntl_fcntl_impl оставив fcntl_ioctl_impl
d5d5746 
Пулл-реквест pythongh-95429 внёс по сути те же изменения, так что фокусируемся
на отсутствующем там fcntl_ioctl_impl.
This was referenced Jul 29, 2022
Closed
Merged
@gst gst force-pushed the fix-fcntl-1024-limit branch from ab78e70 to 3bc8cee Compare July 30, 2022 13:12
@JelleZijlstra
Copy link
Member

I'm fairly sure this will write past the end of the buffer if you pass a buffer that is smaller than PATH_MAX. For example, on MacOS a call like fcntl.fcntl(f.fileno(), fcntl.F_GETPATH, b"") looks like it would write the filename into whatever memory is next to the empty buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

Assignees
No one assigned
Labels
awaiting review DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gst @JelleZijlstra @arhadthedev @bedevere-bot