Remove fcntl_fcntl_impl keeping fcntl_ioctl_impl
#95443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ва разных варианта исправления.
…pl убрал buf[len] = '\0';
Пулл-реквест pythongh-95429 внёс по сути те же изменения, так что фокусируемся на отсутствующем там fcntl_ioctl_impl.
Консольная команда, использованная для обновления:
python Tools/clinic/clinic.py Modules/fcntlmodule.c
Если этого не сделать, автоматическая проверка пулл-реквеста увидит
рассинхронизацию, и у пул-реквеста в статусах будет крестик напротив
"Tests / Check if generated files are up to date".
|
The following commit authors need to sign the Contributor License Agreement: Click the button to sign: |
|
Actually, it was supposed to be opened against zenbooster's repo. |
fcntl_fcntl_impl, оставив fcntl_ioctl_implfcntl_fcntl_impl keeping fcntl_ioctl_impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionfcntl_fcntl_implis already covered by gh-95429 so it's worth to focus onfcntl_ioctl_implinstead by removing duplication of gh-95439.Also, regenerated code that converts Python calls into C ones with checks and conversion of arguments.