Skip to content

Close PRs when PR opened #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 1, 2024

Re: #5 (comment)

The cron was disabled four months ago:

This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days. Enable this workflow to resume scheduled runs.

This triggers the autoclose when opening a PR.

For a demo, see:

(This PR will be autoclosed the next time the schedule runs, we'll just have to re-open it before merge 😅)

@hugovk hugovk mentioned this pull request Oct 1, 2024
Copy link

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! — will it re-run if we re-open a PR? Just wondering what the merge flow looks like for core devs

@Wulian233
Copy link

Looks good!

@@ -4,6 +4,7 @@ permissions:
pull-requests: write

on:
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should let a core dev reopen an auto-closed PR if need be:

GitHub's documentation states:

By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened.

I haven't tested it, but it seems by default we'd have an auto-close loop.

Suggested change
pull_request:
pull_request:
types:
- opened

This comment was marked as off-topic.

@github-actions github-actions bot closed this Oct 1, 2024
@AA-Turner AA-Turner reopened this Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

We do not accept PRs on this repository. Please file an issue at https://github.com/python/cpython requesting an update to the binary packages in this repository.

@github-actions github-actions bot closed this Oct 1, 2024
@hugovk
Copy link
Member Author

hugovk commented Oct 1, 2024

Thanks! — will it re-run if we re-open a PR? Just wondering what the merge flow looks like for core devs

No, it stayed open after re-open (and was later closed by the hourly cron).

@hugovk
Copy link
Member Author

hugovk commented Oct 30, 2024

I'll re-open and merge this :)

@hugovk hugovk reopened this Oct 30, 2024
Copy link

We do not accept PRs on this repository. Please file an issue at https://github.com/python/cpython requesting an update to the binary packages in this repository.

@github-actions github-actions bot closed this Oct 30, 2024
@hugovk
Copy link
Member Author

hugovk commented Oct 30, 2024

Bad timing, got hit by the hourly cron:

image

But GitHub Actions isn't behaving right now (on many repos), with builds taking a long time to start and completed builds showing as yellow. Will try again later when things have settled.

@hugovk hugovk reopened this Oct 30, 2024
@hugovk hugovk merged commit a6b94d2 into python:main Oct 30, 2024
0 of 4 checks passed
@hugovk hugovk deleted the trigger-close-on-open branch October 30, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants