-
-
Notifications
You must be signed in to change notification settings - Fork 30
Close PRs when PR opened #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! — will it re-run if we re-open a PR? Just wondering what the merge flow looks like for core devs
Looks good! |
@@ -4,6 +4,7 @@ permissions: | |||
pull-requests: write | |||
|
|||
on: | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should let a core dev reopen an auto-closed PR if need be:
GitHub's documentation states:
By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened.
I haven't tested it, but it seems by default we'd have an auto-close loop.
pull_request: | |
pull_request: | |
types: | |
- opened |
This comment was marked as off-topic.
This comment was marked as off-topic.
We do not accept PRs on this repository. Please file an issue at https://github.com/python/cpython requesting an update to the binary packages in this repository. |
No, it stayed open after re-open (and was later closed by the hourly cron). |
I'll re-open and merge this :) |
We do not accept PRs on this repository. Please file an issue at https://github.com/python/cpython requesting an update to the binary packages in this repository. |
Re: #5 (comment)
The cron was disabled four months ago:
This triggers the autoclose when opening a PR.
For a demo, see:
(This PR will be autoclosed the next time the schedule runs, we'll just have to re-open it before merge 😅)