Skip to content

PEP 1: Remove legacy reference to pep2pyramid.py #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ncoghlan
Copy link
Contributor

This removes any reference to the technical details of online PEP
publication from PEP 1, replacing it with a reference to the
README in the PEP repository.

It also updates the README with relevant cross-references to the
pythondotorg project (based on some process pointers provided by
Mariatta Wijaya).

Resolves GH-575.

This removes any reference to the technical details of online PEP
publication from PEP 1, replacing it with a reference to the
README in the PEP repository.

It also updates the README with relevant cross-references to the
pythondotorg project (based on some process pointers provided by
Mariatta Wijaya).

Resolves pythonGH-575.
@ncoghlan
Copy link
Contributor Author

@Mariatta @berkerpeksag I'm adjusting the references from the PEPs repo to the online publication process. Does what I've added look right from the pydotorg side?

Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am not an expert on pythondotorg.

@ncoghlan ncoghlan merged commit 499a7c2 into python:master Apr 27, 2018
@ncoghlan
Copy link
Contributor Author

I've gone ahead and merged it, since it's definitely less wrong than what was previously there.

If Berker or Mariatta spot any new problems in the updated text, then I can tackle them in a follow-up PR :)

Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me (and sorry for my late response.) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants