Skip to content

Traducción library/gzip #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 15, 2020
Merged

Traducción library/gzip #1075

merged 7 commits into from
Oct 15, 2020

Conversation

alcides29
Copy link
Contributor

Closes #557

cmaureir
cmaureir requested changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@cmaureir cmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias por tu traducción! dejé un par de comentarios que los puedes aceptar desde Github, si te vas a la pestaña "Files Changed" de tu Pull-request, puedes ir clickeando en "Add suggestion to batch" y cuando acabes podrás hacer un commit con todos los cambios, en vez de agregarlas una a una.

alcides29 and others added 2 commits October 14, 2020 11:11
@alcides29 @cmaureir
Apply suggestions from code review
298c516 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@alcides29
Update gzip.po
45adabe 
Se deja la línea 58 ":term:`file object`" sin traducir
@cmaureir
Copy link
Collaborator

En el Travis nos muestra los siguientes problemas:

cpython/Doc/library/gzip.rst:107: WARNING: inconsistent term references in translated message. original: [':class:`GzipFile`', ':meth:`close`', ':class:`io.BytesIO`', ':class:`io.BytesIO`', ':meth:`~io.BytesIO.getvalue`'], translated: [':meth:`close`', ':class:`GzipFile`', ':class:`io.BytesIO`', ':meth:`~io.BytesIO.getvalue`']

cpython/Doc/library/gzip.rst:139: WARNING: inconsistent term references in translated message. original: [':func:`time.time`', ':attr:`~os.stat_result.st_mtime`', ':func:`os.stat`'], translated: [':func:`time.time`', ':attr:`~os.stat_result.st_mtime`']

cpython/Doc/library/gzip.rst:230: WARNING: inconsistent term references in translated message. original: [':mod:`gzip`'], translated: []

En todos por lo general es que falta un término a traducir, esto pasa porque nos faltan espacios o dejamos "roles de sphinx" (lo que tienen los dos puntos como :term: o :ref: ) juntos a otra cosa, te dejaré un comentario para el primero y tu miras los otros.

Adicionalmente localmente tienes que aplicar powrap al archivo, esto es en tu entorno virtual favorito lo instalas pip install powrap y luego haces un powrap library/gzip.po y subes los cambios que eso modifica 💪

cmaureir
cmaureir reviewed Oct 14, 2020
View reviewed changes
cmaureir
cmaureir reviewed Oct 14, 2020
View reviewed changes
@cmaureir
Copy link
Collaborator

a ver si puedes encontrar el warning de la entrada 138 ;)

cpython/Doc/library/gzip.rst:139: WARNING: inconsistent term references in translated message. original: [':func:`time.time`', ':attr:`~os.stat_result.st_mtime`', ':func:`os.stat`'], translated: [':func:`time.time`', ':attr:`~os.stat_result.st_mtime`']

@alcides29 @cmaureir
Apply suggestions from code review
e9bad3f 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
alcides29
alcides29 commented Oct 14, 2020
View reviewed changes
Copy link
Contributor Author

@alcides29 alcides29 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que encontré el warning del Travis del comentario 139

alcides29
alcides29 commented Oct 14, 2020
View reviewed changes
Copy link
Contributor Author

@alcides29 alcides29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Falta separar objeto de :class:

eamanu
eamanu approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien.

library/gzip.po

# No estoy seguro si statement se traduciría como declaración.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo lo identifico más como sentencia, no se opinan los demas.

@cmaureir cmaureir merged commit 6aac0aa into python:3.8 Oct 15, 2020
@cmaureir
Copy link
Collaborator

Muchas gracias @alcides29 por tu traducción! 🎉 🎉

@alcides29 alcides29 deleted the traduccion-gzip branch October 20, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaureir cmaureir cmaureir approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate library/gzip.po
3 participants
@alcides29 @cmaureir @eamanu