Skip to content

Traduccion c-api/concrete #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2020
Merged

Traduccion c-api/concrete #184

merged 1 commit into from
May 9, 2020

Conversation

cmaureir
Copy link
Collaborator

@cmaureir cmaureir commented May 9, 2020

No description provided.

@gilgamezh gilgamezh self-requested a review May 9, 2020 18:55
gilgamezh
gilgamezh approved these changes May 9, 2020
View reviewed changes
Copy link
Collaborator

@gilgamezh gilgamezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gracias!

@gilgamezh
Copy link
Collaborator

@cmaureir vas a tener que agregar estas palabras al dict

$ pospell -p dict -l es_AR -l es_ES **/*.po

c-api/concrete.po:30:Pasarles

c-api/concrete.po:65:singleton

así pasa el test de travis

gilgamezh
gilgamezh previously requested changes May 9, 2020
View reviewed changes
Copy link
Collaborator

@gilgamezh gilgamezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

está perfecto, solo queda pendiente agregar unas palabras al dict

@cmaureir cmaureir force-pushed the traduccion-concrete branch from 2f269fb to 2dff9b9 Compare May 9, 2020 22:51
@cmaureir
Copy link
Collaborator Author

cmaureir commented May 9, 2020

A ver si ahora pasa :D

@humitos
Copy link
Collaborator

humitos commented May 9, 2020

Perfecto! Gracias!

@humitos humitos dismissed gilgamezh’s stale review May 9, 2020 22:59

Ya lo arregló :)

@humitos humitos merged commit 1c68b8a into python:3.8 May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@gilgamezh gilgamezh gilgamezh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaureir @gilgamezh @humitos