Skip to content

Traduccion faq/library #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
May 13, 2020
Merged

Traduccion faq/library #214

merged 30 commits into from
May 13, 2020

Conversation

sdelquin
Copy link
Contributor

No description provided.

Copy link
Collaborator

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola! Muchas gracias por la Pull Request. ¡Está super bien! 🎉

Hice algunas sugerencias y correciones. ¿Las puedes mirar y corregir? Gracias!

@humitos humitos self-requested a review May 10, 2020 16:58
@humitos humitos mentioned this pull request May 10, 2020
@humitos
Copy link
Collaborator

humitos commented May 12, 2020

@sdelquin este PR está bien para mí --solo quedaría arreglar el Travis que no parece ser un gran problema. ¿Puedes hacerlo?

@humitos
Copy link
Collaborator

humitos commented May 13, 2020

@sdelquin hrm... parece que des-hiciste mis cambios en tus últimos dos commits. ¿Puedes revisarlo?

Copy link
Collaborator

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto! Lo que sigue de "excelente"! Muchas gracias! 😄

@humitos humitos dismissed marian-vignau’s stale review May 13, 2020 16:18

Ya los arregló

@humitos humitos merged commit b2ec573 into python:3.8 May 13, 2020
@sdelquin
Copy link
Contributor Author

Un placer @humitos y @marian-vignau. Gracias por el trabajo que están haciendo. Han sido los primeros revisores de código que he tenido nunca jaja Una bonita experiencia.

@humitos humitos mentioned this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants