Skip to content

Minor fixes while preparing the PDF #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 1, 2022
Merged

Minor fixes while preparing the PDF #2148

merged 6 commits into from
Nov 1, 2022

Conversation

humitos
Copy link
Collaborator

@humitos humitos commented Nov 1, 2022

No description provided.

@humitos humitos requested a review from cmaureir November 1, 2022 11:14
@@ -253,17 +253,16 @@ msgstr ""
"Si tiene una cadena de caracteres de formato realmente larga que no desea "
"dividir, sería bueno si pudiera hacer referencia a las variables que se "
"formatearán por nombre en lugar de por posición. Esto se puede hacer "
"simplemente pasando el dict y usando corchetes ``'[]'`` para acceder a las "
"claves. ::"
"simplemente pasando el diccionario y usando corchetes ``'[]'`` para acceder "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an open question for me as well.
The English documentation uses 'dict' and 'dictionary' all over the place, do I tend to think that the first is when they are referring to the type, rather than the actual meaning. However, on this case they do refer to an actual dict variable, called table https://docs.python.org/3/tutorial/inputoutput.html#the-string-format-method so we could even say "pasando el diccionario table y usando..."

Copy link
Collaborator Author

@humitos humitos Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I, personally, wouldn't add/remove words and just stick with the translated text. Since the variable table is not mentioned in the original paragraph, I wouldn't add it in the translated one.

In this example, in particular, I'd say it refer to "dictionary" as some "generic dictionary" and not to that particular table variable; since table is defined in the next paragraph.

humitos and others added 3 commits November 1, 2022 15:40
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@cmaureir cmaureir merged commit 4f4f96c into 3.11 Nov 1, 2022
@cmaureir
Copy link
Collaborator

cmaureir commented Nov 1, 2022

thanks!

@cmaureir cmaureir deleted the minor-fixes branch March 3, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants