-
Notifications
You must be signed in to change notification settings - Fork 396
Agrego página git diff #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buenísimo! Dejé unos comentarios.
tutorial/.gitattributes
Outdated
@@ -0,0 +1 @@ | |||
*.po diff=podiff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esto no lo pongas en el repositorio, ya que no todos van a tener el podiff
configurado y les va a fallar. Debería haber un archivo local de tu repo dentro de .git/
o similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vale!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@humitos no encuentro una manera de incluir el *.po diff=podiff
en un archivo que sea diferente a .gitattribute.
Y si agregamos el gitattribute
al .gitignore
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
si, mejor agregarlo al gitignore para evitarnos problemas y que la gente lo agregue.
.overrides/git_diff.rst
Outdated
|
||
.. tab:: Linux | ||
|
||
Para instalar brew en Linux ejecutar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yo para Linux no diría de usar brew. Explicaría que hay que instalar podiff. Estamos hablando de la librería de Python podiff? En ese caso probablemente explicaría como instalarlo en el mismo virtualenv que tenemos en el Makefile o incluso lo añadiría allí.
pip install podiff
Siendo usuario de Linux decirme que tengo que instalar brew me parece rarísimo. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops yo instalé brew en Linux :O. No sé si es el mismo módulo el podiff. Dejame que lo pruebe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mejor dejar un comentario de instalarlo con el gestor de paquetes, y dar uno o dos ejemplos y ya.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sí. No recomendemos usar brew
en Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmaureir @humitos @raulcd Retomé este PR, y estuve viendo algunas opciones para no usar brew.
Pude ver que [0] no tiene soporte para py3, y [1] lanza un Exception cuando se ejecuta. Existe también [2]
pero no le he instalado porque parece ser ya una applicación más completa, y que desde mi punto de vista
es demasiado para hacer un diff.
Qué opinan cómo continuar?
[0] https://pypi.org/project/podiff/
[1] https://pypi.org/project/potools/
[2] https://pypi.org/project/PoProofRead/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mejor no darle tanta vuelta, el workflow general es traducir con poedit
, usar powrap
y mirar las palabras con pospell
y ya, como esto es adicional, yo que tu dejo un mensaje que es algo para Python 2 solamente (podiff)
mejor dejas una nota que diga que es solo compatible con Python 2 para podiff y las potools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmaureir que tal quedó?
@eamanu si miras los comentarios pendientes, mergeamos esto a penas los resuelvas :) |
@eamanu te puedo ayudar con este PR? |
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Gracias @eamanu 🎉 :) |
Agrego página que indica como instalar y configurar poediff