Skip to content

Traducido library/types.po #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 4, 2020
Merged

Traducido library/types.po #641

merged 12 commits into from
Aug 4, 2020

Conversation

narvmtz
Copy link
Contributor

@narvmtz narvmtz commented Jul 29, 2020

Closes #558

@narvmtz narvmtz changed the title Traduccion types Traducido library/types.po Jul 29, 2020
cmaureir
cmaureir requested changes Aug 4, 2020
View reviewed changes
Copy link
Collaborator

@cmaureir cmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un par de detalles que encontré, a ver que te parecen.

narvmtz and others added 5 commits August 4, 2020 07:28
@narvmtz @cmaureir
Update library/types.po
0acf541 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@narvmtz @cmaureir
Update library/types.po
be9f19d 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@narvmtz @cmaureir
Update library/types.po
64851b9 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@narvmtz @cmaureir
Update library/types.po
f60d2cb 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@narvmtz @cmaureir
Update library/types.po
5de66b3 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@cmaureir
Copy link
Collaborator

cmaureir commented Aug 4, 2020

hay que pasarle powrap y se arregla la build.
Otra cosa, no es necesario hacer 1 commit por sugerencia, cuando te vas a la pestaña "Files changed" puedes ir agregando todas las sugerencias con el botón "Add suggestion to batch", y luego cuando las tienes todas, puedes hacer 1 commit con ellas.

@cmaureir cmaureir merged commit 6178e1a into python:3.8 Aug 4, 2020
@cmaureir
Copy link
Collaborator

cmaureir commented Aug 4, 2020

gracias @narvmtz 🎉

@narvmtz narvmtz deleted the traduccion-types branch August 6, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaureir cmaureir cmaureir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate library/types.po
2 participants
@narvmtz @cmaureir