Skip to content

Working on floatingpoint #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2018
Merged

Conversation

yichung279
Copy link
Contributor

No description provided.

Copy link
Collaborator

@adrianliaw adrianliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution ✨I've posted some review comments, could you please read it if you have a minute?


#: ../../tutorial/floatingpoint.rst:14
msgid ""
"Floating-point numbers are represented in computer hardware as base 2 "
"(binary) fractions. For example, the decimal fraction ::"
msgstr ""
msgstr "在計算機架構中,浮點數透過二進位小數表示。 例如說,在十進位小數中 ::"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a redundant space after the period. Also, the colons should follow the rule described in the translation guideline. This should be applied to the rest of the translations in this document whenever there are double-colons in the original message.


#: ../../tutorial/floatingpoint.rst:19
msgid ""
"has value 1/10 + 2/100 + 5/1000, and in the same way the binary fraction ::"
msgstr ""
msgstr "可被分為 1/10 + 2/100 + 5/1000 ,同樣的道理,二進位小數 ::"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a redundant space before the first comma.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,I got it.

@@ -47,30 +50,38 @@ msgid ""
"point numbers you enter are only approximated by the binary floating-point "
"numbers actually stored in the machine."
msgstr ""
"不幸的是,大多數十進位小數無法精準地以二進位小數表示。一般的結果為,您輸入的"
"十進位浮點數由實際存在計算機中的二進位浮點數近似。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/近似/逼近/g This should be applied to the rest of the translations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I translated "approximate" as "近似" acrodding to the dictionary of ROC National Academy for Educational Research.
I could use "逼近",if there is a standard or you insist.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, thanks for attaching the link here, could you please add a line in our glossary for this particular vocabulary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay


#: ../../tutorial/floatingpoint.rst:32
msgid ""
"The problem is easier to understand at first in base 10. Consider the "
"fraction 1/3. You can approximate that as a base 10 fraction::"
msgstr ""
"在十進位中,這個問題更容易首先被理解。考慮分數 1/3 ,您可以將其近似為十進位小"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "at first" in the original message does not add too much into the meaning of the sentence, it's ok to just leave "首先" out, or the sentence can be unnatural.

The word "consider" here is more of the meaning of "for example", it can be unnatural to use the direct translation.

There's another redundant space before the comma in the latter sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,"at first"我這邊想很久


#: ../../tutorial/floatingpoint.rst:45
msgid ""
"and so on. No matter how many digits you're willing to write down, the "
"result will never be exactly 1/3, but will be an increasingly better "
"approximation of 1/3."
msgstr ""
"依此類推,不論你願意以多少位數表示小數,最後的結果都無法精準地表示 1/3 ,但你"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant space before the last comma


#: ../../tutorial/floatingpoint.rst:45
msgid ""
"and so on. No matter how many digits you're willing to write down, the "
"result will never be exactly 1/3, but will be an increasingly better "
"approximation of 1/3."
msgstr ""
"依此類推,不論你願意以多少位數表示小數,最後的結果都無法精準地表示 1/3 ,但你"
"還是能越來越精準的表示 1/3 。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/的/地/

Redundant space before the period.


#: ../../tutorial/floatingpoint.rst:49
msgid ""
"In the same way, no matter how many base 2 digits you're willing to use, the "
"decimal value 0.1 cannot be represented exactly as a base 2 fraction. In "
"base 2, 1/10 is the infinitely repeating fraction ::"
msgstr ""
"同樣的道理,不論你願意以多少位數表示二進位小數,十進位小數 0.1 都無法被二進位"
"小數精準的表達。在二進位小數中, 1/10 會是一個無限循環小數 ::"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant space before the fraction.


#: ../../tutorial/floatingpoint.rst:49
msgid ""
"In the same way, no matter how many base 2 digits you're willing to use, the "
"decimal value 0.1 cannot be represented exactly as a base 2 fraction. In "
"base 2, 1/10 is the infinitely repeating fraction ::"
msgstr ""
"同樣的道理,不論你願意以多少位數表示二進位小數,十進位小數 0.1 都無法被二進位"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the translation for "no matter how many base 2 digits you're willing to use" is a bit unnatural, I propose translating it to "不論你使用多少位的二進位數", what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好�,以後會以更接近繁體中文使用者的方式去翻譯。


#: ../../tutorial/floatingpoint.rst:23
msgid ""
"has value 0/2 + 0/4 + 1/8. These two fractions have identical values, the "
"only real difference being that the first is written in base 10 fractional "
"notation, and the second in base 2."
msgstr ""
"可被分為 0/2 + 0/4 + 1/8 。這兩個小數有相同的數值,而唯一真正的不同在於前者以"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a redundant space before the period.

Copy link
Collaborator

@adrianliaw adrianliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revise! There's only a few more details to be fixed on redundant spaces and on grammar, thank you for taking your time!


#: ../../tutorial/floatingpoint.rst:45
msgid ""
"and so on. No matter how many digits you're willing to write down, the "
"result will never be exactly 1/3, but will be an increasingly better "
"approximation of 1/3."
msgstr ""
"依此類推,不論你使用多少位數表示小數,最後的結果都無法精準的表示 1/3,但你還"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/精準的/精準地/ This should also be applied to the next line.

"在十進位中,這個問題更容易被理解。以分數 1/3 為例,您可以將其近似為十進位小"
"數:\n"
"\n"
" ::"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant space before the double colons.


#: ../../tutorial/floatingpoint.rst:14
msgid ""
"Floating-point numbers are represented in computer hardware as base 2 "
"(binary) fractions. For example, the decimal fraction ::"
msgstr ""
"在計算機架構中,浮點數透過二進位小數表示。例如說,在十進位小數中:\n"
"\n"
" ::"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant space before the double colons.


#: ../../tutorial/floatingpoint.rst:49
msgid ""
"In the same way, no matter how many base 2 digits you're willing to use, the "
"decimal value 0.1 cannot be represented exactly as a base 2 fraction. In "
"base 2, 1/10 is the infinitely repeating fraction ::"
msgstr ""
"同樣的道理,不論你願意以多少位數表示二進位小數,十進位小數 0.1 都無法被二進位"
"小數精準的表達。在二進位小數中, 1/10 會是一個無限循環小數:\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant space after the comma.

@@ -47,30 +56,45 @@ msgid ""
"point numbers you enter are only approximated by the binary floating-point "
"numbers actually stored in the machine."
msgstr ""
"不幸的是,大多數十進位小數無法精準的以二進位小數表示。一般的結果為,您輸入的"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/精準的/精準地/ due to the Chinese grammar for adverbs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstanded,sorry. :p

@adrianliaw adrianliaw merged commit 2352742 into python:3.7 Oct 16, 2018
@adrianliaw
Copy link
Collaborator

🍰

beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants