Skip to content

translate library/os.po #: ../../library/os.rst:31 #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 1, 2023

Conversation

Quantum-Spacetime
Copy link

@Quantum-Spacetime Quantum-Spacetime commented Aug 20, 2023

Issue: #594

library/os.po Outdated
Comment on lines 67 to 68
"所有接受檔案路徑和檔案名稱的函式皆接受位元組(bytes) 和字串物件(string "
"objects),且如果回傳檔案路徑或檔案名稱,則會產出相同型態物件。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"所有接受檔案路徑和檔案名稱的函式皆接受位元組(bytes) 和字串物件(string "
"objects),且如果回傳檔案路徑或檔案名稱,則會產出相同型態物件。"
"所有接受檔案路徑和檔案名稱的函式皆接受位元組 (bytes) 和字串物件 (string "
"objects),且如果回傳檔案路徑或檔案名稱,則會產出相同型態物件。"

…y/logging.rst:326 library/logger.po #: ../../library/logging.rst:31
Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@Quantum-Spacetime 提醒一下 一個branch 建議只修改一個文件喔

@rockleona rockleona self-requested a review August 20, 2023 09:16
@@ -422,11 +423,11 @@ msgstr ""

#: ../../library/logging.rst:321
msgid "Adds the specified filter *filter* to this logger."
msgstr ""
msgstr "在該logger內增加指定的filter *filter*。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "在該logger內增加指定的filter *filter*。"
msgstr "在該 logger 內增加指定的 filter *filter*。"


#: ../../library/logging.rst:326
msgid "Removes the specified filter *filter* from this logger."
msgstr ""
msgstr "在該logger 內移除指定的filter *filter*。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "在該logger 內移除指定的filter *filter*。"
msgstr "在該 logger 內移除指定的 filter *filter*。"

library/os.po Outdated
@@ -64,6 +64,8 @@ msgid ""
"objects, and result in an object of the same type, if a path or file name is "
"returned."
msgstr ""
"所有接受檔案路徑和檔案名稱的函式皆接受位元組 (bytes) 和字串物件 (string "
"objects),且如果回傳檔案路徑或檔案名稱,則會產出相同型態物件。"
Copy link
Collaborator

@mattwang44 mattwang44 Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type 指的是 python type (e.g. str, int, dict, ...) 時請翻譯成「型別」

Suggested change
"objects),且如果回傳檔案路徑或檔案名稱,則會產出相同型態物件"
"objects),且如果回傳檔案路徑或檔案名稱,則會產出相同型別的物件"

@weijay0804
Copy link
Contributor

@Quantum-Spacetime
想問一下,你有興趣繼續完成這個 PR 嗎?

@weijay0804
Copy link
Contributor

@rockleona 我有根據 review 的建議進行修改了,要麻煩你再幫我 review 一次~

@weijay0804 weijay0804 requested a review from rockleona August 31, 2023 14:38
Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

應該是最後一個小問題了XD

Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished! LGTM
@Quantum-Spacetime @weijay0804 感謝兩位🙏🏻

@weijay0804 weijay0804 merged commit 6719f35 into python:pycon-sprints Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants