Skip to content

feat: update content from meetup march 2024 #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 29, 2024
Merged

Conversation

rockleona
Copy link
Collaborator

No description provided.

JoycePan810 and others added 16 commits March 10, 2024 03:19
* 更新 library/logging.rst:53

* 修正library/logging.rst:53翻譯內容,格式化改為格式器
* feat: update logging.po with translated text

* Fix translation in logging constructor

* Update library/logging.po

change word

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>

---------

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
* add i18n for logging

* update 。 reviewer suggection for logging
* 更新 library/logging.rst:53

* 修正library/logging.rst:53翻譯內容,格式化改為格式器
* feat: update logging.po with translated text

* Fix translation in logging constructor

* Update library/logging.po

change word

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>

---------

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
* add i18n for logging

* update 。 reviewer suggection for logging
中文標點符號 與 特殊符號 中間不用增加空格

Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
翻譯positional-only

Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
* work on logging.po

* change 參數被解釋 -> 引數被直譯

* add 隔行

* 修正為:在此記錄器上記錄一條層級為
* working on logging

* Update logging.po

* Update library/logging.po

Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>

* Update library/logging.po

Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>

---------

Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
@rockleona rockleona enabled auto-merge (squash) March 17, 2024 08:25
@rockleona rockleona closed this Mar 17, 2024
auto-merge was automatically disabled March 17, 2024 08:29

Pull request was closed

@rockleona rockleona reopened this Mar 17, 2024
@rockleona rockleona requested a review from ken71301 March 17, 2024 08:45
Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed~


#: ../../library/logging.rst:41
msgid ""
"The module provides a lot of functionality and flexibility. If you are "
"unfamiliar with logging, the best way to get to grips with it is to view the "
"tutorials (**see the links above and on the right**)."
msgstr ""
"這個模組提供了很多的功能性以及彈性。如果你對於 logging 不熟悉,熟悉他最好的方"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
"這個模組提供了很多的功能性以及彈性。如果你對於 logging 不熟悉,熟悉他最好的方"
"這個模組提供了很多的功能性以及彈性。如果你對於 logging 不熟悉,熟悉它最好的方"

@@ -135,6 +137,9 @@ msgid ""
"ancestor loggers' handlers - neither the level nor filters of the ancestor "
"loggers in question are considered."
msgstr ""
"如果此屬性評估為 true,則在此 logger 發生的事件會被傳到更高階(上代)loggers"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logged 是記錄

Suggested change
"如果此屬性評估為 true,則在此 logger 發生的事件會被傳到更高階(上代)loggers"
"如果此屬性評估為 true,則在此 logger 被記錄的事件會被傳到更高階(上代)loggers"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

然後 handler 在 官方術語表 翻成處理函式

@@ -135,6 +137,9 @@ msgid ""
"ancestor loggers' handlers - neither the level nor filters of the ancestor "
"loggers in question are considered."
msgstr ""
"如果此屬性評估為 true,則在此 logger 發生的事件會被傳到更高階(上代)loggers"
" 的處理器和所有附加在此 logger 的任何處理器。訊息會直接傳到上代 loggers 的"
"處理器 - 在問題中上代 loggers 的層級不會被考慮。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filters 的翻譯不見了

@@ -187,6 +192,9 @@ msgid ""
"delegation to the parent when the logger is a non-root logger). Note that "
"the root logger is created with level :const:`WARNING`."
msgstr ""
"當一個日誌記錄器被建立時,記錄等級會被設定成 :const:`NOTSET` (當此日誌記錄器"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger 的上下文沒有統一~

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

level 應該是 層級

Copy link
Collaborator Author

@rockleona rockleona Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我先翻譯成 日誌記錄器

@@ -392,6 +400,8 @@ msgid ""
"Logs a message with level :const:`WARNING` on this logger. The arguments are "
"interpreted as for :meth:`debug`."
msgstr ""
"在此記錄器上記錄一條層級為 :const:`WARNING` 的訊息。"
"這些引數被直譯為 :meth:`debug`。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這邊的 as for 我看原文好像比較接近

Suggested change
"這些引數被直譯為 :meth:`debug`。"
"這些引數被直譯的方式與 :meth:`debug` 相同"

待討論~

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這邊我也認同 Payon 的翻譯。

@@ -1139,7 +1149,7 @@ msgstr ""
#: ../../library/logging.rst:917 ../../library/logging.rst:931
#: ../../library/logging.rst:959 ../../library/logging.rst:977
msgid "You shouldn't need to format this yourself."
msgstr ""
msgstr "你不需要自己格式化它。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: shouldnt 本身包含 不應該/不該之意,這句我會想把這個意思放出來(勸阻看文件的別這樣做)

Suggested change
msgstr "你不需要自己格式化它。"
msgstr "你不應該需要自己格式化它。"

@rockleona rockleona requested a review from ken71301 March 28, 2024 14:44
Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@rockleona rockleona merged commit 6026538 into 3.12 Mar 29, 2024
1 check passed
@rockleona rockleona deleted the event-march-2024 branch March 29, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants