Introduce logo placement API endpoint #1849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berinhard
commented
Aug 24, 2021
ewdurbin
requested changes
Aug 25, 2021
…somehow delete the CSV file
4e11447 to
b4ee966
Compare
ewdurbin
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is complementary to #1806 work. It introduces a new endpoint
/api/v2/sponsors/logo-placement/to list all of the sponsor logo placement information. This endpoint replaces the previousgen_sponsors_csvmanagement command we've created to start with the integrations with the logo placement server.@ewdurbin, although this PR has all the code needed by the endpoint the CSV file still have invalid URLs for the logo images, such as https://pypi.org/static/images/sponsors/color/google.png. Feel free to update the CSV file with the new you'll generate after you go through the process of updating the uploaded files.