Remove old type-ignore explanation comments not removed in #8280 #11513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Feb 29, 2024
| @@ -98,7 +98,6 @@ class object: | |||
| __annotations__: dict[str, Any] | |||
| @property | |||
| def __class__(self) -> type[Self]: ... | |||
| # Ignore errors about type mismatch between property getter and setter | |||
There was a problem hiding this comment.
Noticed by @Akuli in #11496 (comment)
Added in #5092
Avasam
commented
Feb 29, 2024
| @@ -93,7 +93,6 @@ class WeakValueDictionary(MutableMapping[_KT, _VT]): | |||
|
|
|||
| class KeyedRef(ref[_T], Generic[_KT, _T]): | |||
| key: _KT | |||
| # This __new__ method uses a non-standard name for the "cls" parameter | |||
Avasam
commented
Feb 29, 2024
| @@ -241,7 +241,6 @@ class MetadataPathFinder(DistributionFinder): | |||
| @classmethod | |||
| def find_distributions(cls, context: DistributionFinder.Context = ...) -> Iterable[PathDistribution]: ... | |||
| if sys.version_info >= (3, 10): | |||
| # Yes, this is an instance method that has a parameter named "cls" | |||
There was a problem hiding this comment.
Don't feel strongly, but this one is kind of funny and might help a human who is quickly glancing at stubs
There was a problem hiding this comment.
I have no issue leaving it in if you feel it has value outside of explaining a type: ignore comment
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Feb 29, 2024
| @@ -241,7 +241,6 @@ class MetadataPathFinder(DistributionFinder): | |||
| @classmethod | |||
| def find_distributions(cls, context: DistributionFinder.Context = ...) -> Iterable[PathDistribution]: ... | |||
| if sys.version_info >= (3, 10): | |||
| # Yes, this is an instance method that has a parameter named "cls" | |||
There was a problem hiding this comment.
Don't feel strongly, but this one is kind of funny and might help a human who is quickly glancing at stubs
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8280 removed some redundant
#type: ignore, but not the associated comments.