Skip to content

Use error codes for type ignores #8280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Jul 12, 2022

Disable reportSelfClsParameterName for pyright as this is out of typeshed's
control

Closes: #7497

Disable reportSelfClsParameterName for pytype as this is out of typeshed's
control

Closes: python#7497
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@github-actions

This comment has been minimized.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit faae950 into python:master Jul 12, 2022
@srittau srittau deleted the error-codes2 branch July 12, 2022 18:15
AlexWaygood added a commit that referenced this pull request Jul 12, 2022
This wasn't possible prior to #8280, which disabled pyright's reportSelfClsParameterName check
Avasam added a commit to Avasam/typeshed that referenced this pull request Feb 29, 2024
danieleades pushed a commit to danieleades/typeshed that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace # type: ignores without error codes
2 participants