Update pyright CI test to use the latest version of pyright (1.1.118). #5092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Enable all but one of pyright's strictest checks. Add a "# type: ignore" to `__new__` method in `weakref.KeyRef` because it uses a non-standard name for the `cls` parameter, which is flagged as an error by pyright.
| @@ -89,7 +89,7 @@ class object: | |||
| @property | |||
| def __class__(self: _T) -> Type[_T]: ... | |||
| @__class__.setter | |||
| def __class__(self, __type: Type[object]) -> None: ... # noqa: F811 | |||
| def __class__(self, __type: Type[object]) -> None: ... # type: ignore # noqa: F811 | |||
There was a problem hiding this comment.
Would be nice to add a comment explaining what is being ignored here
There was a problem hiding this comment.
Sure, I can do that. There didn't seem to be a precedent for this, which is why I initially left it out.
There was a problem hiding this comment.
Thanks! I think it's helpful in the future for documenting why we have these type ignores.
JelleZijlstra
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable all but one of pyright's strictest checks. Add a "# type: ignore" to
__new__method inweakref.KeyRefbecause it uses a non-standard name for theclsparameter, which is flagged as an error by pyright.