stdlib: Add missing conditionals for Unix-only API #7384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
541e5de to
777e8b4
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
We do allow rebase merging on this repo, but that means one of the commits will be pre-commit reformatting things. Personally I'd prefer squash-merging so each commit maps cleanly to a PR. I would clean up the commit message to list the specific changes you made. |
JelleZijlstra
approved these changes
Mar 2, 2022
777e8b4 to
1b25073
Compare
|
I rebased the PR to merge the formatting changes with the individual commits and added the PR number to each commit message. I hope that addresses your concerns. I strongly prefer separate changes to be split up across separate commits, because it makes the git history more readable. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
pushed a commit
that referenced
this pull request
Mar 7, 2022
JelleZijlstra
pushed a commit
that referenced
this pull request
Mar 7, 2022
JelleZijlstra
added a commit
that referenced
this pull request
Mar 7, 2022
See #7384 and #7443 (comment) (thanks @AlexWaygood for diagnosing).
JelleZijlstra
added a commit
that referenced
this pull request
Mar 7, 2022
See #7384 and #7443 (comment) (thanks @AlexWaygood for diagnosing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd prefer these commits to be merged without squashing to produce a more readable git log.