re: Build debug libraries when CMAKE_BUILD_TYPE is set to Debug #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
commented
Dec 13, 2018
| @@ -33,6 +33,10 @@ if(CMAKE_CROSSCOMPILING) | |||
| cmake_minimum_required(VERSION 3.3) # Version introducing CROSSCOMPILING_EMULATOR | |||
| endif() | |||
|
|
|||
| if(MSVC) | |||
There was a problem hiding this comment.
Should be WIN32, that way building in Debug on windows using Ninja will work as expected.
| @@ -122,10 +122,13 @@ add_python_extension(_testmultiphase REQUIRES IS_PY3 SOURCES _testmultiphase.c) | |||
| # debug tool to trace memory blocks allocated by Python | |||
| add_python_extension(_tracemalloc BUILTIN REQUIRES IS_PY3 SOURCES hashtable.c _tracemalloc.c) | |||
| add_python_extension(_weakref BUILTIN REQUIRES IS_PY3 SOURCES _weakref.c) | |||
| math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}") | |||
| if(NOT "${CMAKE_BUILD_TYPE}" STREQUAL "Debug") | |||
There was a problem hiding this comment.
Should probably be something like :
set(_limited_definition)
if(NOT "${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}")
set(_limited_definition "Py_LIMITED_API=0x${_limited_api_version}0000")
endif()
That said, the approach should still be tweaked to handle the case of Visual Studio where CMAKE_CONFIGURATION_TYPES is defined
There was a problem hiding this comment.
@dbrnz I had an other look at this, and if Py_LIMITED_API must not be defined when doing Debug build, relying on a newer version of CMake supporting generator expression would be the way to go.
That way, we will be able to do something like this:
math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}")
target_compile_definition(xxlimited PRIVATE $<$<NOT:$<CONFIG:Debug>>:${_limited_definition}>)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede PR #151