Skip to content

re: Build debug libraries when CMAKE_BUILD_TYPE is set to Debug #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

re: Build debug libraries when CMAKE_BUILD_TYPE is set to Debug #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
127ec49
Add `_d` postfix to MS Windows library names for CMake debug builds.
dbrnz Aug 28, 2016
ad9fe66
Debug builds can't have `Py_LIMITED_API` set.
dbrnz Aug 29, 2016
defd5f4
Only add `_d` postfix to Windows debug builds when using Microsoft's …
dbrnz Aug 29, 2016
8cc39fe
Remove redundant test on CMAKE_BUILD_TYPE.
dbrnz Sep 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ if(CMAKE_CROSSCOMPILING)
cmake_minimum_required(VERSION 3.3) # Version introducing CROSSCOMPILING_EMULATOR
endif()

if(MSVC)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be WIN32, that way building in Debug on windows using Ninja will work as expected.

set(CMAKE_DEBUG_POSTFIX "_d")
endif()

# Include helper functions
include(cmake/CMakeChecks.cmake)
include(cmake/Extensions.cmake)
Expand Down
7 changes: 5 additions & 2 deletions cmake/extensions/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,13 @@ add_python_extension(_testmultiphase REQUIRES IS_PY3 SOURCES _testmultiphase.c)
# debug tool to trace memory blocks allocated by Python
add_python_extension(_tracemalloc BUILTIN REQUIRES IS_PY3 SOURCES hashtable.c _tracemalloc.c)
add_python_extension(_weakref BUILTIN REQUIRES IS_PY3 SOURCES _weakref.c)
math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}")
if(NOT "${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be something like :

set(_limited_definition)
if(NOT "${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
    math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}")
    set(_limited_definition "Py_LIMITED_API=0x${_limited_api_version}0000")
endif()

That said, the approach should still be tweaked to handle the case of Visual Studio where CMAKE_CONFIGURATION_TYPES is defined

Copy link
Contributor Author

@jcfr jcfr Dec 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbrnz I had an other look at this, and if Py_LIMITED_API must not be defined when doing Debug build, relying on a newer version of CMake supporting generator expression would be the way to go.

That way, we will be able to do something like this:

math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}")
target_compile_definition(xxlimited PRIVATE $<$<NOT:$<CONFIG:Debug>>:${_limited_definition}>)

math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}")
set(_limited_definition "Py_LIMITED_API=0x${_limited_api_version}0000")
endif()
add_python_extension(xxlimited REQUIRES IS_PY3 BUILD_TESTING
SOURCES xxlimited.c
DEFINITIONS Py_LIMITED_API=0x${_limited_api_version}0000
DEFINITIONS ${_limited_definition}
NO_INSTALL
)
add_python_extension(xxsubtype BUILTIN REQUIRES IS_PY3 SOURCES xxsubtype.c)
Expand Down