Skip to content

Upgrade3.10.0 #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 60 commits into from
Closed

Upgrade3.10.0 #281

wants to merge 60 commits into from
+2,044 −1,239

Conversation

fbordignon
Copy link
Contributor

I am trying to add the support for python 3.10.0

I did some work based on @dand-oss branch https://github.com/dand-oss/python-cmake-buildsystem/tree/3.9.0

Reached this issue via Slicer/Slicer#5014

I am not sure if what I did can be merged but it is compiling with an error on xxlimited. I don't really know what it is and what it does.

I hope to help with this initial effort and get it working with python 3.10 soon.

jcfr and others added 30 commits November 9, 2020 17:56
@jcfr
cmake: Support extracting version from patchlevel for alpha/beta/rc r…
5b82a71 
…eleases
@jcfr
Add support for building Python 3.7
61a1f62 
* Rename "Modules/random.c" to "Modules/bootstrap_hash.c"
  See python/cpython@6b4be19
      bpo-22257: Small changes for PEP 432. (#1728)
      PEP 432 specifies a number of large changes to interpreter startup code,
      including exposing a cleaner C-API. The major changes depend on a number
      of smaller changes. This patch includes all those smaller changes.

* Remove bundled copy of libffi (Closes #27979)
  See python/cpython@f40d4dd
      An installed copy of libffi is now required for building _ctypes on
      any platform but OSX and Windows.
@jcfr
Fix extraction of version info introducing "PythonExtractVersionInfo"…
2aa28e1 
… module
@jcfr
ci: Update appveyor/circleci/travis to test python version 3.7.0b2
2a9fdad
@jcfr
cmake: Fix generation of downloading for pre-release python versions
0409df9
@dbrnz
Add checksums for Python 3.5.6, 3.6.8, 3.6.9. Set default to 3.6.9
66273e0
@dbrnz
3.7.x: Add checksums for Python 3.7.0 to 3.7.4
8817126
@dbrnz
cmake: Add initial support for building Python 3.7.x
4014712
@dbrnz
3.7.x: Add support for building new modules
f2f852f
@dbrnz
3.7.x: Check for and set RTLD_* macros.
98d991e
@dbrnz
cmake: The name of the import initialisation function is version depe…
0440315 
…ndent.
@dbrnz
ci: Updates travis and CircleCI
0707cfc
@dbrnz
Add support for building _uuid module
735e56f
add patches for 3.7
29e704e
cmake: Set default python version to 3.7.4
ef6ec7f
_PYTHONFRAMEWORK="" to extensions
eecddf0
On Linux, uses external libffi for python >= 3.7
f12e318 
Since python/cpython@f40d4ddff (Closes python/cpython#27979: Remove
bundled copy of libffi), external version of libffi is required
on linux.
cmake: exclude _uuid module from python < 3.7
32683b7
cmake: use external zlib starting with python 3.7
36bda7b
cmake: add python 2.7, 3.5, 3.6 version
4cac5e4
cmake: enable Python 3.7.6/7
17d1a19
ci: update test environments for 3.7.6/7
7bcdbde
unit tests: have cmake list unit tests automatically
075ea24 
manual method using python interpreter was not kept up
unit tests: skip non-terminating test_ssl unit test on 3.6 and 3.7
7c457e2
FEATURE - log cmake openssl/expat/sqlite/zlib find_x
c622eea
3.8.x: compatible 3.7.x - USE_SYSTEM_FFI libraries
a321870
FIRST - added Python 3.8.5
909f16a
3.8.x: add new internal/include directory
2bc9193
3.8.x: zipimport is now pure python
6fb2529
3.8.x: pgen moved to pure python
e107193 
https://bugs.python.org/issue36623
@fbordignon fbordignon mentioned this pull request Nov 9, 2021
Closed
2 tasks
@fbordignon
Copy link
Contributor Author

extension_xxlimited is complaining that it can't find python3.lib which is now python3stub.lib

Since python 3.10 there are no more .def files see python/cpython@2c6e4e9 so I removed the cmake targets that used those and I suspect that one of them was force generating python3.lib

They are using the #pragma and other directives to build the .libs automatically and for some reason the python3.lib is not built from the libpython3-shared project. Maybe it is not detecting any exports and not building pyhton3.lib.

@fbordignon
Copy link
Contributor Author

Python 3.10 dropped the libffi sources and added it as a dependency for windows and linux.
ffi is a dependency for ctypes
We need to add libffi to the build system.
@jcfr can you cmakefy the libffi for us? I figure that as you did it for zlib you could do it quicker. Found this one that may help https://github.com/newlawrence/Libffi

Thank you

@fbordignon
Copy link
Contributor Author

I've managed to build libffi with cmake and manually add a reference to ctypes using this branch:
https://github.com/am11/libffi/tree/feature/cmake-build-configs

I've successfully bootstrapped pip with ensurepip

Now there are some problems with the other python targets inside the slicer python build that I am addressing right now.
If someone can help me include the above linked project as a part of the buildsystem it would be great!

@fbordignon
Copy link
Contributor Author

Ok, this commit solved an issue with limited libs. The build is working for 3.10 from this branch.

The question that remains is about libffi.
Should we include an option to build libffi inside this project?

I am mentioning it because ctypes depends on libffi and I believe something should be done for the case of this line

I believe it should be ok to inlcude such a stable and small lib inside the build system. Or at least give the developer an option to build it with this project or use the external one.

@fbordignon
Copy link
Contributor Author

fbordignon commented Nov 17, 2021 •
edited
Loading

@lassoan Turns out the hack I've deleted from the 3.9.8 branch was not needed after all. I've reverted it with 81cbdd1

On python 3.10 there are no more .def files so python3.dll is generated solely based on python3dll.c, which changed a bit from python39. The catch was a compile warning that I did not pay attention to, it was saying that it expected a ")" but found PYTHON_DLL_NAME. Simply defining it as I did in 4b8db2d solves the issue and generates the python.lib and python3.dll correctly. This current branch is working for 3.10 and should make it easier to transition to 3.10 when the time comes.

@jamesobutler jamesobutler mentioned this pull request Jun 28, 2023
Closed
@bjia56 bjia56 mentioned this pull request Dec 19, 2023
Closed
@jcfr jcfr mentioned this pull request Apr 15, 2025
Open
@jcfr
Copy link
Contributor

jcfr commented Jun 2, 2025

Closing. Support for Python 3.10 was added through the following pull request:

@jcfr jcfr closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbordignon @jcfr @dbrnz