Skip to content

Update conda-recipe for use with conda-build >= 3.0 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2018

Conversation

murrayrm
Copy link
Member

This PR updates the conda recipe so that it works correctly with conda-build 3.0. The basic change is to extract the version information directly from git, using jinja commands.

This PR should run correctly using Travis CI, fixing issue #159.

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.9%) to 65.825% when pulling 91d5355 on murrayrm:fix_conda into 05d6bc5 on python-control:master.

@murrayrm
Copy link
Member Author

Integration checks look OK. Most are failing because of issue #164 (scipy 1.0 compatibility), but otherwise running properly. There is also an unknown issue with python3.3 that seems to be related to an error while installing package defaults::openssl-1.0.1k-1.

@murrayrm murrayrm mentioned this pull request Dec 23, 2017
@murrayrm murrayrm added this to the 0.8.0 milestone Dec 27, 2017
@murrayrm
Copy link
Member Author

murrayrm commented Dec 28, 2017

Followup comment: need to rethink this PR a bit. By removing make_version.py, I messed up the automatic versioning that @cwrowley put into place in PR #52. Probably still need to run make_version.py in the conda recipe, but not rely on it for the version information in conda (since __conda_version__ is not supported).

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 087046f on murrayrm:fix_conda into ** on python-control:master**.

@murrayrm
Copy link
Member Author

murrayrm commented Dec 29, 2017

I've updated this PR to leave make_version.py in place, but still use jinja for generating the version information in meta.yaml. I squashed the commits so that the history is clean. This PR will allow conda-build 3.0 to work correctly.

Travis CI checks fail due to SciPy c1.0 incompatibility. This is expected and solved by PR #170.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 087046f on murrayrm:fix_conda into ** on python-control:master**.

@roryyorke
Copy link
Contributor

FWIW, Python 3.3 is end-of-life (see https://devguide.python.org/#status-of-python-branches ). Are you aware of any python-control users requiring it? If not, we might as well drop it.

@murrayrm
Copy link
Member Author

Travis CI testing for Python 3.3 (and 3.4) has been removed in PR #169. I don't see any need to support Python 3.3 going forward => haven't bother to debug the issue that was described above.

@murrayrm murrayrm merged commit 9457031 into python-control:master Jan 2, 2018
@murrayrm murrayrm deleted the fix_conda branch January 2, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants