-
Notifications
You must be signed in to change notification settings - Fork 438
Update conda-recipe for use with conda-build >= 3.0 #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Integration checks look OK. Most are failing because of issue #164 (scipy 1.0 compatibility), but otherwise running properly. There is also an unknown issue with python3.3 that seems to be related to an error while installing package |
Followup comment: need to rethink this PR a bit. By removing |
Changes Unknown when pulling 087046f on murrayrm:fix_conda into ** on python-control:master**. |
I've updated this PR to leave Travis CI checks fail due to SciPy c1.0 incompatibility. This is expected and solved by PR #170. |
Changes Unknown when pulling 087046f on murrayrm:fix_conda into ** on python-control:master**. |
FWIW, Python 3.3 is end-of-life (see https://devguide.python.org/#status-of-python-branches ). Are you aware of any python-control users requiring it? If not, we might as well drop it. |
Travis CI testing for Python 3.3 (and 3.4) has been removed in PR #169. I don't see any need to support Python 3.3 going forward => haven't bother to debug the issue that was described above. |
This PR updates the conda recipe so that it works correctly with
conda-build
3.0. The basic change is to extract the version information directly from git, using jinja commands.This PR should run correctly using Travis CI, fixing issue #159.