-
Notifications
You must be signed in to change notification settings - Fork 440
Plot heat maps of state spaces #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b18d56
to
331c1a4
Compare
2 similar comments
@don4get It would be useful if you could split this into two PRs, as you suggest. I have some questions about the use of heat maps; will post those once these have been split. |
331c1a4
to
398828d
Compare
Hello, I splitted the PR in two, feel free to ask questions about the feature presented here. |
I'm not sure I understand the reasoning for having this function in the control systems toolbox. Is there a reason that looking at the heat map for state space matrices is useful? Since the matrices are not uniquely defined, seems like the heat map is kind of arbitrary. |
I suggested this PR beacause I find it useful to look a system: is it sparse? in which form is it written? It also helps in one wants to check if his system looks well written at a glance. Let say someone wants to solve a problem on a python notebook. First thing is to right the system. To check for typo, he might want a It s not about precise result, just to give insight. |
My inclination at this point is to drop this PR. It seems to add functionality that is not specific to control systems (could be used for any matrix). Marking as |
Hello!
Thank you for maintaining this repo.
Here is a little contribution to plot heat maps of state spaces or matrices.
Example is available in appropriate folder.
While I got used to your coding convention, I also slightly cleaned
nichols.py
. If you prefer me to send two separate PR, just tell me :)