Skip to content

Plot heat maps of state spaces #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

don4get
Copy link
Contributor

@don4get don4get commented Dec 30, 2018

Hello!

Thank you for maintaining this repo.

Here is a little contribution to plot heat maps of state spaces or matrices.
Example is available in appropriate folder.
While I got used to your coding convention, I also slightly cleaned nichols.py. If you prefer me to send two separate PR, just tell me :)

@don4get don4get force-pushed the feature/state-space-plot branch from 3b18d56 to 331c1a4 Compare December 30, 2018 16:21
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 76.808% when pulling 331c1a4 on don4get:feature/state-space-plot into 0d94329 on python-control:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 76.808% when pulling 331c1a4 on don4get:feature/state-space-plot into 0d94329 on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 76.808% when pulling 331c1a4 on don4get:feature/state-space-plot into 0d94329 on python-control:master.

@coveralls
Copy link

coveralls commented Dec 30, 2018

Coverage Status

Coverage decreased (-1.1%) to 77.075% when pulling 398828d on don4get:feature/state-space-plot into bcf5382 on python-control:master.

@don4get don4get changed the title Feature/state space plot Plot heat maps of state spaces Dec 31, 2018
@murrayrm
Copy link
Member

murrayrm commented Dec 31, 2018

@don4get It would be useful if you could split this into two PRs, as you suggest. I have some questions about the use of heat maps; will post those once these have been split.

@don4get don4get force-pushed the feature/state-space-plot branch from 331c1a4 to 398828d Compare January 4, 2019 21:03
@don4get don4get mentioned this pull request Jan 4, 2019
@don4get
Copy link
Contributor Author

don4get commented Jan 4, 2019

Hello, I splitted the PR in two, feel free to ask questions about the feature presented here.
Happy coding!

@murrayrm
Copy link
Member

murrayrm commented Jan 5, 2019

I'm not sure I understand the reasoning for having this function in the control systems toolbox. Is there a reason that looking at the heat map for state space matrices is useful? Since the matrices are not uniquely defined, seems like the heat map is kind of arbitrary.

@don4get
Copy link
Contributor Author

don4get commented Jan 5, 2019

I suggested this PR beacause I find it useful to look a system: is it sparse? in which form is it written? It also helps in one wants to check if his system looks well written at a glance. Let say someone wants to solve a problem on a python notebook. First thing is to right the system. To check for typo, he might want a state space pretty printing function, which is in fact this feature.

It s not about precise result, just to give insight.

Spyder has this kind of behavior in the variable brower:
image

@murrayrm
Copy link
Member

My inclination at this point is to drop this PR. It seems to add functionality that is not specific to control systems (could be used for any matrix). Marking as wontfix but leaving in place for a while in case others want to chime in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants