Skip to content

Fix python2 print in examples #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fix python2 print in examples #266

wants to merge 6 commits into from

Conversation

don4get
Copy link
Contributor

@don4get don4get commented Jan 4, 2019

This one is to answer to issue #208, concerning the python2 print style.

I realized the example testing the import of slycot was not working and I fixed it.

@don4get don4get force-pushed the fix/print-python2-style-examples branch from 0a8e5f0 to 1e6c704 Compare January 4, 2019 23:44
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.225% when pulling 1e6c704 on don4get:fix/print-python2-style-examples into bcf5382 on python-control:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.225% when pulling 1e6c704 on don4get:fix/print-python2-style-examples into bcf5382 on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.225% when pulling 1e6c704 on don4get:fix/print-python2-style-examples into bcf5382 on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.225% when pulling 1e6c704 on don4get:fix/print-python2-style-examples into bcf5382 on python-control:master.

@coveralls
Copy link

coveralls commented Jan 4, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 78.225% when pulling 1e6c704 on don4get:fix/print-python2-style-examples into bcf5382 on python-control:master.

@murrayrm
Copy link
Member

murrayrm commented Jan 5, 2019

@don4get Can you rebase this against the current master? There were some changes in some of the pending PRs that conflicted. Thanks.

@roryyorke
Copy link
Contributor

Sorry, I should have noted that #263 fixes #208, at least w.r.t. Python-2 style print.

@don4get don4get changed the title Fix/print python2 style examples Clean examples Jan 5, 2019
@don4get
Copy link
Contributor Author

don4get commented Jan 5, 2019

@roryyorke Well done ;)
I rebased and cleaned my branch -> new purpose, minor: clean two examples.

@don4get don4get changed the title Clean examples Fix python2 print in examples Jan 5, 2019
@don4get don4get closed this Jan 5, 2019
@don4get don4get mentioned this pull request Jan 5, 2019
Merged
@don4get
Copy link
Contributor Author

don4get commented Jan 5, 2019

Since I renamed the branch, I had to create another PR: #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@don4get @coveralls @murrayrm @roryyorke