Skip to content

Add _repr_latex_ for Jupyter notebooks #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2019

Conversation

alchemyst
Copy link
Contributor

@alchemyst alchemyst commented Feb 24, 2019

This allows better representation inside the browser:

image

@coveralls
Copy link

coveralls commented Feb 24, 2019

Coverage Status

Coverage decreased (-0.5%) to 77.92% when pulling 6cbe066 on alchemyst:master into e4e7a0d on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-13.5%) to 64.872% when pulling 426215e on alchemyst:master into 31e6944 on python-control:master.

@murrayrm
Copy link
Member

Change looks fine, but getting a Travis CI error.

It would be nice to put in this type of functionality for the other LTI subtypes (StateSpace, FRD, etc). Any chance you have the time and inclination to do that as well?

@alchemyst
Copy link
Contributor Author

I'd be happy to take a run at it, but perhaps we could start by opening issues for the others? I'd specifically like to know what format you'd prefer for the state space.

@murrayrm
Copy link
Member

@alchemyst Can you merge changes from latest master to get Travis CI working again (see PR #280 for more info). Thanks.

@alchemyst
Copy link
Contributor Author

@murrayrm

@repagh
Copy link
Member

repagh commented Mar 27, 2019

Nice, looks good.
Would it be worthwhile to build the outstr as a list, and at the end return the string with
''.join(outstr)
I expect that to be faster.

@alchemyst
Copy link
Contributor Author

@repagh Done.

My initial implementation was a copy-paste of the current __str__. Perhaps we should add an issue for someone to make the same changes there?

@repagh
Copy link
Member

repagh commented Apr 5, 2019

@murrayrm I think this looks OK to merge

@murrayrm murrayrm added this to the 0.8.2 milestone Apr 6, 2019
@murrayrm murrayrm merged commit c30746a into python-control:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants