As planned, the Travis checks are failing, because I added a flake8 run to the travis configuration.
These are the errors/warings that are left, where it would be good to have some input about what to do with them :

control/lti.py:173:30: E721 do not compare types, use 'isinstance()'
control/modelsimp.py:413:5: F841 local variable 'Ymat' is assigned to but never used
control/frdata.py:371:13: E722 do not use bare 'except'
control/frdata.py:480:5: E722 do not use bare 'except'
control/freqplot.py:601:9: E722 do not use bare 'except'```

control/lti.py:173:30: E721 do not compare types, use 'isinstance()'

Using isintance(thing, str) is fine for type checking. The if type(thing) == str above these lines is not a good idiom.

https://stackoverflow.com/questions/152580/whats-the-canonical-way-to-check-for-type-in-python

control/modelsimp.py:413:5: F841 local variable 'Ymat' is assigned to but never used

Remove it.

control/frdata.py:371:13: E722 do not use bare 'except'
control/frdata.py:480:5: E722 do not use bare 'except'
control/freqplot.py:601:9: E722 do not use bare 'except

Add specific exceptions.

You also did not follow my suggestion to submit 1 PR per py file (or per sub-package at max).

You also did not follow my suggestion to submit 1 PR per py file (or per sub-package at max).

Since there is only 1 subpackage, I followed that suggestion. I didn't think fixing 25+ individual files and creating pull requests for all of them would be easier to manage. The person reviewing could always review one file at a time.

control/lti.py:173:30: E721 do not compare types, use 'isinstance()'

Using isintance(thing, str) is fine for type checking. The if type(thing) == str above these lines is not a good idiom.

https://stackoverflow.com/questions/152580/whats-the-canonical-way-to-check-for-type-in-python

control/modelsimp.py:413:5: F841 local variable 'Ymat' is assigned to but never used

Remove it.

control/frdata.py:371:13: E722 do not use bare 'except'
control/frdata.py:480:5: E722 do not use bare 'except'
control/freqplot.py:601:9: E722 do not use bare 'except

Add specific exceptions.

Right. I understand what the errors mean. The point was to get suggestions by someone who wrote the code (or, has more commits, or wants to review) before I change it to something else.

I offered my time and suggestions and you clearly don't respect that from your response. I have nothing more to offer.

Coverage decreased (-0.05%) to 78.328% when pulling 3832700 on jgspiro:feature/flake8 into e4e7a0d on python-control:master.

Coverage decreased (-0.05%) to 78.328% when pulling 13468a9 on jgspiro:feature/flake8 into e4e7a0d on python-control:master.

Would it be better to just configure & run flake8 with the --exit-zero flag? Then the checks won't fail due to flake8, and we can slowly, unit-by-unit, fix the formatting and code.

I don't feel happy either with over 30 changed files in one PR and I would not like this to get hurried through.

This has to be done in a separate Travis CI job to make sure that later no new PEP8 problems creep in. Over SciPy, we created a very fast job that runs pycodestyle and pyflakes that checks specifically this and a few other cosmetics. Then you just need to see the green checkmark and not review everything.