Rework at step_info #293
Closed
Rework at step_info #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating last commits
|
Oops, I did break the tests for step, really missed somewhere. I'll look it soon and pull again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I did some rework trying to fix some issues that it found using
control.step_info(),specially when I tried to compare with MATLAB for some system with inverted output likesys = control.TransferFunction([0.0002, -0.0002], [1, 0.01, 0.0002]).Another thread that I found was that the output resolution for
control.step_response()for discrete systems, so I increased it using the idea of MATLAB, that produces the output with all samples for a particular discrete system from 0 to steady state. Also, I noticed that MATLAB thinks differently about how to define the size of the arrays for step... but i didn't mess with it this time, it is working fine.Besides that, I have no clue about what undershoot should be like.