Skip to content

handle non proper tf in _common_den() #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2020
Merged

handle non proper tf in _common_den() #370

merged 2 commits into from
Mar 21, 2020

Conversation

bnavigator
Copy link
Contributor

Proposed fix for #369

@coveralls
Copy link

coveralls commented Jan 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+2.5%) to 84.625% when pulling a0986c5 on bnavigator:fix-369 into 66bee9d on python-control:master.

@bnavigator bnavigator mentioned this pull request Jan 28, 2020
Closed
repagh
repagh reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@repagh repagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If I am not mistaken it can be simplified a little

murrayrm
murrayrm reviewed Mar 18, 2020
View reviewed changes
Copy link
Member

@murrayrm murrayrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but a couple of small suggestions. If you can reject or update, I'll merge when done.

@murrayrm murrayrm merged commit a09d059 into python-control:master Mar 21, 2020
repagh pushed a commit to repagh/python-control that referenced this pull request Jun 9, 2020
@bnavigator @repagh
handle non proper tf in _common_den() (python-control#370)
e9dadf5
@murrayrm murrayrm mentioned this pull request Jul 11, 2020
Closed
@bnavigator bnavigator deleted the fix-369 branch July 26, 2020 14:39
@murrayrm murrayrm mentioned this pull request Dec 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murrayrm murrayrm murrayrm left review comments

@repagh repagh repagh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnavigator @coveralls @murrayrm @repagh