do not override squeeze parameter in forced_response #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@murrayrm, this is a fix but it changes user facing behavior. I am not sure whether it should go to 0.8.4 or 0.9 |
|
I think we could argue that this sort of fix is OK in 0.8.4, given that it probably wasn't really used much (since nobody complained that it was broken). |
|
Yes, looking at git blame, the squeeze parameter was introduced into master by #295 last year and only existed in 0.8.3 since January. No |
|
Any objections to merge now? |
|
OK by me. |
|
Excercising my newly received privileges then. Thanks for adding me to the team 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squeeze=Falsedoes not work forforced_response()because the parameter is unnecessarily overridden by a shortcut alias to np.squeeze.The current code timeresp_test.py advertises to test this, but actually does not. (#438 does now, that's how I stumbled over it.)