Skip to content

Consistent return values for lqe and lqr #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 26, 2020
Merged

Consistent return values for lqe and lqr #477

merged 10 commits into from
Dec 26, 2020

Conversation

murrayrm
Copy link
Member

This PR addresses issue #418 by making the return values for lqe consistent with those of lqr (and care and dare). Specifically, the list of returned eigenvalues is a 1D array rather than being converted to a 2D array or matrix (depending on config settings).

Resolves #418.

@coveralls
Copy link

coveralls commented Dec 24, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 86.355% when pulling becd0ab on murrayrm:lqe-consistent-lqr into 120a926 on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 86.222% when pulling becd0ab on murrayrm:lqe-consistent-lqr into 120a926 on python-control:master.

@murrayrm murrayrm merged commit 38f29c7 into python-control:master Dec 26, 2020
@murrayrm murrayrm mentioned this pull request Dec 26, 2020
Closed
@murrayrm murrayrm deleted the lqe-consistent-lqr branch December 28, 2020 22:43
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

doc inconsistency about return type of lqr - matrix vs array
2 participants
@murrayrm @coveralls