Skip to content

Interpret str-type args to interconnect as non-sequence #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2022
Merged

Interpret str-type args to interconnect as non-sequence #698

merged 1 commit into from
Jan 30, 2022

Conversation

roryyorke
Copy link
Contributor

If the arguments inputs or outputs (or their aliases input or
output) are of type str, treat as a list containing that string.

Fixes gh-692.

@roryyorke
Interpret str-type args to interconnect as non-sequence
37d3148 
If the arguments `inputs` or `outputs` (or their aliases `input` or
`output`) are of type str, treat as a list containing that string.

Fixes python-controlgh-692.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 93.595% when pulling 37d3148 on roryyorke:rory/interconnect-io-str into e8db508 on python-control:master.

bnavigator
bnavigator approved these changes Jan 29, 2022
View reviewed changes
Copy link
Contributor

@bnavigator bnavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murrayrm murrayrm merged commit e10855e into python-control:master Jan 30, 2022
@roryyorke roryyorke deleted the rory/interconnect-io-str branch February 5, 2022 04:50
@murrayrm murrayrm added this to the 0.9.2 milestone Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnavigator bnavigator bnavigator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.2
Development

Successfully merging this pull request may close these issues.

Interconnect treats string as list
4 participants
@roryyorke @coveralls @bnavigator @murrayrm