-
Notifications
You must be signed in to change notification settings - Fork 438
fix gain handling in rlocus and sisotool #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…that the plots start with. Deprecate kvect kwarg with warning. rlocus now doesn't recomupte kvect if it is passed
Added some more fixes to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
current problem is that if you want to pass an initial gain to
sisotool
to plot as starting point gain in the various plots, an error is raised if it is not an array. so you have to dosisotool(sys, kvect=(1.1, ))
which is awkward. With this fix,you can doupdate: changed function call to look likesisotool(sys, kvect=1.1)
sisotool(sys, initial_gain=1.1)