Add extra information to nyquist plots #997
Conversation
|
It would be nice to have unit tests, even if they call the code to get coverage (better would be to check to make sure the lines are in the right place). If the system is discrete time, are these still the right circles to draw? Any interaction with axis scaling? Eg, if all of the action is very near the origin, might this reset the axes in a way that makes it harder to see the Nyquist plot? If so, is there a better way to do that (eg, fix the axes and let the circle disappear at the edges of the axes)? |
This works as well for discrete systems. And tests have now been added. |
control/freqplot.py
Outdated
| If 'True', displays the unit circle, to read gain crossover frequency. | ||
|
|
||
| mt_circles : array_like, optional | ||
| draws circles corresponding to the given magnitudes of sensitivity |
There was a problem hiding this comment.
For consistency, start phrase with a capital letter and end in a period.
control/freqplot.py
Outdated
| draws circles corresponding to the given magnitudes of sensitivity | ||
|
|
||
| ms_circles : array_like, optional | ||
| draws circles corresponding to the given magnitudes in complementary sensitivity |
There was a problem hiding this comment.
For consistency, start phrase with a capital letter and end in a period.
efc975f to
1f05e52
Compare
ee68801 to
10d2010
Compare
|
I rebased this onto the current main branch and added the ability to set the line style for the circles using |
Adds the possibility to add the unit circle (to get gain crossover frequency), Ms-circle (sensitivity) and Mt-circle (complementary sensitivity) to nyquist plots similar to the approach taken in JuliaControl