Skip to content

Specify CA certificate #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emberian opened this issue Jan 13, 2017 · 4 comments
Closed

Specify CA certificate #204

emberian opened this issue Jan 13, 2017 · 4 comments
Assignees

Comments

@emberian
Copy link

In requests, one can set verify to the path of a CA certificate used to verify the the connection. This is really useful for CE instances when orgs run their own CA (ie, "self-signed"). This feature would allow me to not have to use ssl_verify=False.

@gpocentek
Copy link
Contributor

Definitely an interesting feature to implement. Thanks for the suggestion :)

@gpocentek gpocentek self-assigned this Jan 21, 2017
@mdhausman
Copy link

It looks like this has been implemented? When I set ssl_verify='path/to/my/signed/cert.pem', it uses that cert appropriately, with no InsecureRequestWarnings. Exception being when I try to set ssl_verify from a config file as documented in #270

@mdhausman
Copy link

mdhausman commented Jul 24, 2017

Finally getting around to looking into this.

Yeah, it looks like under the hood this is already exactly what requests does and that we should be able to use it that way. Furthermore, this can be done safely as this behavior appears even in the earliest version of requests supported by python-gitlab.

mdhausman pushed a commit to wayfair-archive/python-gitlab that referenced this issue Jul 24, 2017
mdhausman pushed a commit to wayfair-archive/python-gitlab that referenced this issue Jul 24, 2017
mdhausman pushed a commit to wayfair-archive/python-gitlab that referenced this issue Jul 31, 2017
mdhausman pushed a commit to wayfair-archive/python-gitlab that referenced this issue Aug 1, 2017
mdhausman pushed a commit to wayfair-archive/python-gitlab that referenced this issue Aug 1, 2017
mdhausman pushed a commit to wayfair-archive/python-gitlab that referenced this issue Aug 3, 2017
mdhausman pushed a commit to wayfair-archive/python-gitlab that referenced this issue Aug 3, 2017
mdhausman pushed a commit to wayfair-archive/python-gitlab that referenced this issue Aug 4, 2017
@gpocentek
Copy link
Contributor

Fixed by @mdhausman in #294.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants